Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

cipd: add mobileprovision CIPD package #55449

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Sep 26, 2024

Adds instructions for creating updated CIPD packages containing a new provisioning profile that goes with an updated signing certificate, for use on Chromium CI bots.

These are part of a broader set of steps required to renew our development signing certificate annually, as described in cl/678826297 (Google-internal).

Issue: flutter/flutter#152888

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Adds instructions for creating updated CIPD packages containing a new
provisioning profile that goes with an updated signing certificate, for
use on Chromium CI bots.

Issue: flutter/flutter#152888
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey
Copy link
Contributor

test-exempt: Config only.

Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2024
@auto-submit auto-submit bot merged commit 11a86fd into flutter:main Sep 26, 2024
30 checks passed
@cbracken cbracken deleted the mobile-provision-cipd branch September 26, 2024 17:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 27, 2024
…155799)

flutter/engine@5351777...e57b440

2024-09-26 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55464)
2024-09-26 [email protected] [Impeller] remove entity pass and re-combine canvas implementations. (flutter/engine#55019)
2024-09-26 [email protected] Roll Skia from e986bd33fb33 to 9ebb7c3640a1 (3 revisions) (flutter/engine#55466)
2024-09-26 [email protected] Roll Skia from 5f6ea5ff8401 to e986bd33fb33 (1 revision) (flutter/engine#55465)
2024-09-26 [email protected] Remove and inline dependencies on `build_root` for a constant. (flutter/engine#55441)
2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (#55450)" (flutter/engine#55463)
2024-09-26 [email protected] cipd: add mobileprovision CIPD package (flutter/engine#55449)
2024-09-26 [email protected] Roll Skia from b2c5f640cb44 to 5f6ea5ff8401 (1 revision) (flutter/engine#55462)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants