This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Reverts "Add SurfaceProducer#onSurfaceAvailable, deprecate onSurfaceCreated. (#55418)" (#55450)"
#55463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Sep 26, 2024
auto-submit
bot
deleted the
revert_7af5b384314d2a28bc6ee9e00dcc17a22e457d20
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
… deprecate `onSurfaceCreated`. (flutter#55418)" (flutter#55450)" (flutter/engine#55463)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
… deprecate `onSurfaceCreated`. (flutter#55418)" (flutter#55450)" (flutter/engine#55463)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
… deprecate `onSurfaceCreated`. (flutter#55418)" (flutter#55450)" (flutter/engine#55463)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
… deprecate `onSurfaceCreated`. (flutter#55418)" (flutter#55450)" (flutter/engine#55463)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
… deprecate `onSurfaceCreated`. (flutter#55418)" (flutter#55450)" (flutter/engine#55463)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2024
… deprecate `onSurfaceCreated`. (flutter#55418)" (flutter#55450)" (flutter/engine#55463)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 27, 2024
…155799) flutter/engine@5351777...e57b440 2024-09-26 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55464) 2024-09-26 [email protected] [Impeller] remove entity pass and re-combine canvas implementations. (flutter/engine#55019) 2024-09-26 [email protected] Roll Skia from e986bd33fb33 to 9ebb7c3640a1 (3 revisions) (flutter/engine#55466) 2024-09-26 [email protected] Roll Skia from 5f6ea5ff8401 to e986bd33fb33 (1 revision) (flutter/engine#55465) 2024-09-26 [email protected] Remove and inline dependencies on `build_root` for a constant. (flutter/engine#55441) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (#55450)" (flutter/engine#55463) 2024-09-26 [email protected] cipd: add mobileprovision CIPD package (flutter/engine#55449) 2024-09-26 [email protected] Roll Skia from b2c5f640cb44 to 5f6ea5ff8401 (1 revision) (flutter/engine#55462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gnprice
pushed a commit
to rajveermalviya/zulip-flutter
that referenced
this pull request
Sep 27, 2024
Changelog: https://pub.dev/packages/video_player_android/changelog This update addresses a few bug fixes, including the suppression of deprecation warnings for `onSurfaceCreated`, which was introduced in an early version of the Impeller-compatible Texture APIs. For more info, see note of the migration guide: https://docs.flutter.dev/release/breaking-changes/android-surface-plugins#migration-guide Without this update, Android builds will fail with Flutter SDK versions after the following change that landed yesterday: flutter/engine#55463 flutter/flutter@7bb9352 due to our strict warnings as errors config in `app/build.gradle`. The build error would look like this: /…/video_player_android-2.7.3/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java:88: warning: [removal] onSurfaceCreated() in Callback has been deprecated and marked for removal public void onSurfaceCreated() { ^ error: warnings found and -Werror specified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #55450
Initiated by: matanlurey
Reason for reverting: Fixed forward in flutter/packages#7712.
Original PR Author: auto-submit[bot]
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
Reverts: #55418
Initiated by: bdero
Reason for reverting: Engine->Framework roll breakage
Original PR Author: matanlurey
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Closes flutter/flutter#155131.
Not only did I rename the method, but I also changed the contract slightly - now
onSurfaceAvailableis only invoked afteronSurfaceDestroyedhas been called. The cost is a singleboolean, and it honestly makes the API make a lot more sense than someone having to track this themselves./cc @johnmccutchan (OOO), and @flutter/android-reviewers.