Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Remove android_jit_release_x86." #56634

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Revert "Remove android_jit_release_x86." #56634

merged 1 commit into from
Nov 16, 2024

Conversation

zanderso
Copy link
Member

Reverts #56548

Failing roll to the framework, the tool is still looking for these artifacts.

@matanlurey
Copy link
Contributor

Will need to remove https://github.com/flutter/flutter/blob/ec2ab541dd71e8ee800b190671b476b80311edb6/packages/flutter_tools/lib/src/flutter_cache.dart#L913.

@matanlurey matanlurey mentioned this pull request Nov 15, 2024
Closed
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Nov 16, 2024

auto label is removed for flutter/engine/56634, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2024
@matanlurey
Copy link
Contributor

The only failure is the forever present exec_script("ios_sdk.py", ios_sdk_args, "list lines") timeout, so given this is blocking the roll on a Friday afternoon I'm going to force merge, and I can own un-reverting this on Monday.

@matanlurey matanlurey merged commit 238adab into main Nov 16, 2024
31 of 33 checks passed
@matanlurey matanlurey deleted the revert-56548-remove-android-jit-release branch November 16, 2024 00:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 16, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2024
@engine-flutter-autoroll
238adab9a Revert "Remove android_jit_release_x86." (flutter/engine#…
346bfee 
…56634)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 16, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions) (#…
1ef8d51 
…159015)

Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions)

flutter/engine@619804c...f649330

2024-11-16 [email protected] Roll Skia from 1ef3b910e064 to
6b0f264bde33 (6 revisions) (flutter/engine#56635)
2024-11-16 [email protected] Revert "Remove
`android_jit_release_x86`." (flutter/engine#56634)
2024-11-15 [email protected] Move SetRenderTargetType to
EmbedderTestCompositor (flutter/engine#56626)
2024-11-15 [email protected] Roll Dart SDK from
b62dadb14d82 to eccb15756020 (2 revisions) (flutter/engine#56630)
2024-11-15 [email protected] [TextInput] Add
TextInputType.webSearch (#15762) (flutter/engine#56428)
2024-11-15 [email protected] [web] Send the correct view ID with
semantics actions (flutter/engine#56595)
2024-11-15 [email protected] [macos] early
return to suppress clang-tidy warning (flutter/engine#56588)
2024-11-15 [email protected] [Impeller] libImpeller: Tinker on the
README to cross reference the SDK and the example.
(flutter/engine#56623)
2024-11-15 [email protected] [fuchsia] MaybeRunInitialVsyncCallback
should only called once (flutter/engine#56429)
2024-11-15 [email protected] Move mac clangd build from x64 to arm
(flutter/engine#56567)
2024-11-15 [email protected] Added assert for
opengles thread safety (flutter/engine#56585)
2024-11-15 [email protected] [Impeller] enable OpenGL fallback on
Android. (flutter/engine#56591)
2024-11-15 [email protected] [Impeller] Maintain
separate queues of GLES operations for each thread in the reactor
(flutter/engine#56573)
2024-11-15 [email protected] Roll Dart SDK from
abe86ca4eb01 to b62dadb14d82 (2 revisions) (flutter/engine#56615)
2024-11-15 [email protected] Roll Skia from b730eb340852 to
1ef3b910e064 (4 revisions) (flutter/engine#56613)
2024-11-15 [email protected] Roll Fuchsia Linux SDK from
JkpuAsLzcmYLzf1iX... to UpSQzyXGUhMfedYIh... (flutter/engine#56611)
2024-11-15 [email protected] Roll Dart SDK from
bf0eeb9d929c to abe86ca4eb01 (1 revision) (flutter/engine#56610)
2024-11-15 [email protected] Roll Skia from e5fda8472b21 to
b730eb340852 (1 revision) (flutter/engine#56608)
2024-11-15 [email protected] Roll Skia from 8ff65da4b8bf to
e5fda8472b21 (1 revision) (flutter/engine#56603)
2024-11-15 [email protected] Move TestMetalContext/Surface to testing
namespace (flutter/engine#56602)
2024-11-15 [email protected] Roll Dart SDK from
343b9fc6eafe to bf0eeb9d929c (1 revision) (flutter/engine#56604)
2024-11-15 [email protected] [Impeller] Don't enable KHR_debug on
Angle. (flutter/engine#56601)
2024-11-15 [email protected] [Impeller] libImpeller: Reset the GL
state when transitioning control back to the embedder.
(flutter/engine#56597)
2024-11-15 [email protected] Roll Skia from 8946ea477b42 to
8ff65da4b8bf (2 revisions) (flutter/engine#56600)
2024-11-14 [email protected] [Impeller] Put test components in the
testing namespace. (flutter/engine#56594)
2024-11-14 [email protected] [Impeller] libImpeller: Add a warning
about OpenGL state being trampled. (flutter/engine#56599)
2024-11-14 [email protected] Embedder: Refactor EmbedderConfigBuilder by
backend (flutter/engine#56598)
2024-11-14 [email protected] Migrate Metal translation units to Obj-C++
(flutter/engine#56592)
2024-11-14 [email protected] Roll Dart SDK from
db4d7d52db48 to 343b9fc6eafe (1 revision) (flutter/engine#56590)
2024-11-14 [email protected] iOS,macOS: Build/test
test_metal_surface_unittests (flutter/engine#56586)
2024-11-14 [email protected] Roll Skia from 3222456e63dc to
8946ea477b42 (2 revisions) (flutter/engine#56587)
2024-11-14 [email protected] Roll Skia from 16178bf63de7 to
3222456e63dc (3 revisions) (flutter/engine#56584)
2024-11-14 [email protected] [Android] Fix Slider semantics double
tap behaviors (flutter/engine#56452)
2024-11-14 [email protected] Roll Dart SDK from
a3b6652100c8 to db4d7d52db48 (1 revision) (flutter/engine#56581)
2024-11-14 [email protected] Move Vulkan context to
EmbedderTestContextVulkan (flutter/engine#56571)
2024-11-14 [email protected] Roll Skia from a076435073fc to
16178bf63de7 (1 revision) (flutter/engine#56579)
2024-11-14 [email protected] Roll Skia from 70553189e4e8 to
a076435073fc (1 revision) (flutter/engine#56577)
2024-11-14 [email protected] Roll Skia from fa52f2c1ddba to
70553189e4e8 (1 revision) (flutter/engine#56576)
2024-11-14 [email protected] Roll Dart SDK from
3f05b3540cb2 to a3b6652100c8 (3 revisions) (flutter/engine#56575)
2024-11-14 [email protected] Roll Skia from ddbd8d1cb8d8 to
fa52f2c1ddba (3 revisions) (flutter/engine#56574)
2024-11-14 [email protected] [Android] choose 24 bit depth
buffer. (flutter/engine#56553)
2024-11-14 [email protected] Roll Skia from 3750b8939c7f to
ddbd8d1cb8d8 (1 revision) (flutter/engine#56562)
2024-11-14 [email protected] Move FlMouseCursorHandler from
FlView to FlEngine (flutter/engine#56026)
2024-11-14 [email protected] [Impeller] force software resize
usage for GLES backend. (flutter/engine#56511)
2024-11-14 [email protected] Roll Dart SDK from
66ab1774bfe9 to 3f05b3540cb2 (2 revisions) (flutter/engine#56564)
2024-11-14 [email protected] Embedder: Refactor EmbedderTestContext
creation (flutter/engine#56563)
...
matanlurey added a commit that referenced this pull request Nov 18, 2024
@matanlurey
Revert "Revert "Remove android_jit_release_x86." (#56634)"
9a0631f 
This reverts commit 238adab.
@matanlurey matanlurey mentioned this pull request Nov 18, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Nov 18, 2024
@matanlurey
Re-land "Remove android_jit_release_x86." (#56681)
68ef504 
Reverts #56634 (flutter/flutter#159011 has merged).
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
@zanderso
Revert "Remove android_jit_release_x86." (flutter/engine#56634)
abb5c06 
Reverts flutter/engine#56548

Failing roll to the framework, the tool is still looking for these
artifacts.
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
@matanlurey
Re-land "Remove android_jit_release_x86." (flutter/engine#56681)
d2d49ca 
Reverts flutter/engine#56634 (flutter#159011 has merged).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanderso @matanlurey