This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Use single_root_scheme when compiling platform (#6402)" #6431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 360d446.
chinmaygarde
approved these changes
Oct 4, 2018
tvolkert
approved these changes
Oct 4, 2018
aam
approved these changes
Oct 4, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...5340f42 git log 74662ab..5340f42 --no-merges --oneline 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 4, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...5fe7e37 git log 74662ab..5fe7e37 --no-merges --oneline 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...83151d9 git log 74662ab..83151d9 --no-merges --oneline 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (flutter/engine#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...58fbd1f git log 74662ab..58fbd1f --no-merges --oneline 58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (flutter/engine#6435) 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (flutter/engine#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 4, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...58fbd1f git log 74662ab..58fbd1f --no-merges --oneline 58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (flutter/engine#6435) 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (flutter/engine#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...58fbd1f git log 74662ab..58fbd1f --no-merges --oneline 58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (flutter/engine#6435) 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (flutter/engine#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2018
flutter/engine@74662ab...58fbd1f git log 74662ab..58fbd1f --no-merges --oneline 58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (flutter/engine#6435) 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (flutter/engine#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Oct 4, 2018
Also fix the paragraph test. flutter/engine@74662ab...58fbd1f git log 74662ab..58fbd1f --no-merges --oneline 58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (flutter/engine#6435) 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (flutter/engine#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (flutter/engine#6432) 5340f42 Revert &flutter#34;Use single_root_scheme when compiling platform (flutter#6402)&flutter#34; (flutter/engine#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle&flutter#39;s trace (flutter/engine#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (flutter/engine#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (flutter/engine#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (flutter/engine#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (flutter/engine#6404) 2c5d0c4 [rapidjson] Fix import statements (flutter/engine#6418) c2128fc Create a benchmarking target for the shell. (flutter/engine#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (flutter/engine#6424) 191168c Disable line_height tests on Windows (flutter/engine#6423) 061cc66 Fix ideographic baseline to match spec. (flutter/engine#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (flutter/engine#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (flutter/engine#6417) 7e3b41d Roll src/third_party/skia 08417bccf256..bfa76f20bfcf (4 commits) (flutter/engine#6416) 69ae569 Do not register UI-related native functions in secondary isolates (flutter/engine#6401) 19c135c Roll src/third_party/skia b627af80e3a4..08417bccf256 (8 commits) (flutter/engine#6415) 65b886b Roll src/third_party/skia be8193c9313a..b627af80e3a4 (1 commits) (flutter/engine#6414) 360d446 Use single_root_scheme when compiling platform (flutter/engine#6402) c7a5abf Roll src/third_party/skia deb512045e6a..be8193c9313a (1 commits) (flutter/engine#6413)
aam
added a commit
to aam/engine
that referenced
this pull request
Oct 9, 2018
…er#6402)" (flutter#6431)" This reverts commit 5340f42, relands single root filesystem that is needed for reusable platform kernel files, that is safe to land now since dart roll c048bec has the fix for previously broken dependency file generation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 360d446.
Causing problems currently when trying to build for a physical device in the device lab - may work after rolling https://dart-review.googlesource.com/c/77985
/cc @jensjoha @aam @a-siva @GaryQian