This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Use single_root_scheme when compiling platform (#6402)" #6473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#6402)" (flutter#6431)" This reverts commit 5340f42, relands single root filesystem that is needed for reusable platform kernel files, that is safe to land now since dart roll c048bec has the fix for previously broken dependency file generation.
jensjoha
approved these changes
Oct 9, 2018
aam
changed the title
|
https://cirrus-ci.com/task/5462978816114688 seems to be green, yet Cirrus status on github is not being updated. Ignoring. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2018
flutter/engine@08af410...289c6b1 git log 08af410..289c6b1 --no-merges --oneline 289c6b1 Revert "Revert "Use single_root_scheme when compiling platform (flutter#6402)" (flutter#6431)" (flutter/engine#6473) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2018
flutter/engine@08af410...289c6b1 git log 08af410..289c6b1 --no-merges --oneline 289c6b1 Revert "Revert "Use single_root_scheme when compiling platform (#6402)" (#6431)" (flutter/engine#6473) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5340f42 (#6431), relands single root filesystem that is needed for reusable platform kernel files, that is safe to land now since dart roll c048bec has the fix for previously broken dependency file generation.