Show option to open widget preview in separate browser in the case of embedded error#8701
Merged
Merged
Conversation
helin24
changed the title
jwren
approved these changes
Jan 8, 2026
helin24
added
the
autosubmit
pq
approved these changes
Jan 8, 2026
jwren
pushed a commit
that referenced
this pull request
Jan 8, 2026
Follow up to #8701 The widget preview was loading multiple times because the `whenComplete` listener was being added for each line from the widget preview server output. To verify this is working, check `dash.log` and ensure that this only appears once, not multiple times: ``` 2026-01-08 08:44:28 io.flutter.widgetpreview.WidgetPreviewPanel [INFO ] Widget preview URL received: http://localhost:62494 2026-01-08 08:44:28 io.flutter.widgetpreview.WidgetPreviewPanel [INFO ] Embedded browser is available: true ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8605 by showing an error panel in the case that the embedded browser cannot be found / loaded. To test, make sure the widget preview can open in the normal case, then replace
FlutterUtils.embeddedBrowser(project)withnullto test the error case.I will be making a separate PR to fix another issue where the widget preview panel seems to render multiple times.
CC @bkonyi