Skip to content

Remove multiple loads of widget preview#8702

Merged
jwren merged 3 commits into
flutter:mainfrom
helin24:widget-preview-repeat
Jan 8, 2026
Merged

Remove multiple loads of widget preview#8702
jwren merged 3 commits into
flutter:mainfrom
helin24:widget-preview-repeat

Conversation

@helin24

@helin24 helin24 commented Jan 8, 2026

Copy link
Copy Markdown
Member

Follow up to #8701

The widget preview was loading multiple times because the whenComplete listener was being added for each line from the widget preview server output.

To verify this is working, check dash.log and ensure that this only appears once, not multiple times:

2026-01-08 08:44:28 io.flutter.widgetpreview.WidgetPreviewPanel [INFO   ] Widget preview URL received: http://localhost:62494  
2026-01-08 08:44:28 io.flutter.widgetpreview.WidgetPreviewPanel [INFO   ] Embedded browser is available: true  

@helin24 helin24 requested review from jwren and pq January 8, 2026 18:19
@jwren jwren merged commit 4d67017 into flutter:main Jan 8, 2026
8 checks passed
@helin24 helin24 deleted the widget-preview-repeat branch January 8, 2026 22:45

@pq pq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants