Add dashTool and dashIdeName params#8969
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DevToolsUrl class to include dashTool and dashIdeName parameters in the generated URL, utilizing a new getIdeName() helper method to retrieve the IDE version. A corresponding unit test was added to verify the URL construction. The review identified that the ide parameter requires URL encoding to prevent invalid URLs and raised concerns regarding the use of global state in getIdeName(), suggesting that the IDE name should be passed via the builder to improve testability.
Member
Author
jwren
approved these changes
May 11, 2026
jwren
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8968
An example DevTools URL:
http://127.0.0.1:9104/?ide=Android-Studio&dashTool=intellij-plugins&dashIdeName=Android+Studio&backgroundColor=191a1c&theme=dark&embedMode=many&hide=home,inspector,deep-links,extensions,debugger&ideFeature=toolWindow