Update tokens to 5.0.0 #153385

QuncCccccc · 2024-08-13T18:48:00Z

This PR is to

Update the Material Design tokens to 5.0.0
4 color roles in Light mode have different default values
onPrimaryContainer: Primary10 -> Primary30
onSecondaryContainer: Secondary10 -> Secondary30
onTertiaryContainer: Tertiary10 -> Tertiary30
onErrorContainer: Error10 -> Error30

new tokens added in list.json
md.comp.menu.list-item.* tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(Update Material tokens to 0.162 #122388)

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

dev/tools/gen_defaults/data/list.json

flutter-dashboard · 2024-08-13T20:07:12Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #153385 at sha cae4bc5

TahaTesser

LGTM!

guidezpl

Will there be an accompanying doc for this breaking change?

QuncCccccc · 2024-08-14T17:41:14Z

Will there be an accompanying doc for this breaking change?

Should I send an email to flutter-announce@? It seems there's no failures in customer_testing and Google testing, so probably not counted as breaking changes, but we do have some golden test failures:) Looks like based on this doc, we should just send an announcement. Any suggestions:)?

Update: Sent an announcement to Flutter public announcement group and Discord:) Thanks for helping the review!

flutter/flutter@cc13cd1...99f00a1 2024-08-15 [email protected] Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (flutter/flutter#153487) 2024-08-14 [email protected] Update tokens to 5.0.0 (flutter/flutter#153385) 2024-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.1 to 3.26.2 (flutter/flutter#153468) 2024-08-14 [email protected] Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (flutter/flutter#153464) 2024-08-14 [email protected] Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (flutter/flutter#153465) 2024-08-14 [email protected] Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (flutter/flutter#153463) 2024-08-14 [email protected] Lint sync (flutter/flutter#153453) 2024-08-14 [email protected] manual pub roll w/ gradle updates (flutter/flutter#153403) 2024-08-14 [email protected] Update docs to use new Android version in the engine (flutter/flutter#151601) 2024-08-14 [email protected] move some tool TESTOWNERS entries to andrew (flutter/flutter#153400) 2024-08-14 [email protected] Slider shows visual label of value on focus (flutter/flutter#152960) 2024-08-14 [email protected] Add `Row` and `Column` widgets specific `spacing` tests (flutter/flutter#153353) 2024-08-14 [email protected] Delay `DropdownMenu` filtering until text input (flutter/flutter#152368) 2024-08-14 [email protected] Update cherry pick issue template's PR field (flutter/flutter#153381) 2024-08-14 [email protected] Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (flutter/flutter#153436) 2024-08-14 [email protected] [web] Pass `--no-source-maps` instead of `--extra-compiler-option=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417) 2024-08-14 [email protected] Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (flutter/flutter#153413) 2024-08-14 [email protected] Move `@_debugOnly` documentation in `framework.dart` to be more visible to IDE. (flutter/flutter#153134) 2024-08-13 [email protected] Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (flutter/flutter#153394) 2024-08-13 [email protected] fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (flutter/flutter#152198) 2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.1 (flutter/flutter#153395) 2024-08-13 [email protected] Roll Packages from d9a6de8 to e4f2247 (4 revisions) (flutter/flutter#153383) 2024-08-13 [email protected] Roll pub packages (flutter/flutter#153380) 2024-08-13 [email protected] Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (flutter/flutter#153377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR is to * Update the Material Design tokens to 5.0.0 * 4 color roles in **Light mode** have different default values `onPrimaryContainer`: Primary10 -> Primary30 `onSecondaryContainer`: Secondary10 -> Secondary30 `onTertiaryContainer`: Tertiary10 -> Tertiary30 `onErrorContainer`: Error10 -> Error30         ![Screenshot 2024-08-13 at 12 53 03â�¯PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5) * new tokens added in list.json * `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(flutter#122388)

This PR is to add a breaking change page for the Material 3 token change in the material library(flutter/flutter#153722, flutter/flutter#153385). ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.

Update tokens to 5.0.0

8013190

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 13, 2024

Update theme data test

cae4bc5

QuncCccccc requested review from guidezpl, Piinks and TahaTesser August 13, 2024 20:03

QuncCccccc marked this pull request as ready for review August 13, 2024 20:03

TahaTesser reviewed Aug 13, 2024

View reviewed changes

dev/tools/gen_defaults/data/list.json Show resolved Hide resolved

flutter-dashboard bot added the will affect goldens Changes to golden files label Aug 13, 2024

TahaTesser approved these changes Aug 13, 2024

View reviewed changes

QuncCccccc mentioned this pull request Aug 13, 2024

Tracking for new tokens #153397

Open

2 tasks

guidezpl approved these changes Aug 14, 2024

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2024

auto-submit bot merged commit 108a355 into flutter:master Aug 14, 2024
143 checks passed

engine-flutter-autoroll mentioned this pull request Aug 15, 2024

Manual roll Flutter from cc13cd1f1191 to 99f00a130923 (24 revisions) flutter/packages#7418

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2024

108a355 Update tokens to 5.0.0 (flutter/flutter#153385)

d5eda57

engine-flutter-autoroll mentioned this pull request Aug 15, 2024

Roll Flutter from cc13cd1f1191 to 99f00a130923 (24 revisions) flutter/packages#7419

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2024

108a355 Update tokens to 5.0.0 (flutter/flutter#153385)

aa352cf

Piinks mentioned this pull request Aug 16, 2024

Flutter Framework Team: Notable Commits #121415

Closed

QuncCccccc mentioned this pull request Dec 9, 2024

Migration guide for M3 token update flutter/website#11480

Merged

4 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

108a355 Update tokens to 5.0.0 (flutter/flutter#153385)

11b4965

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

108a355 Update tokens to 5.0.0 (flutter/flutter#153385)

a2ea5c6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update tokens to 5.0.0 #153385

Update tokens to 5.0.0 #153385

Uh oh!

QuncCccccc commented Aug 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

flutter-dashboard bot commented Aug 13, 2024

Uh oh!

TahaTesser left a comment

Uh oh!

guidezpl left a comment

Uh oh!

QuncCccccc commented Aug 14, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Update tokens to 5.0.0 #153385

Update tokens to 5.0.0 #153385

Uh oh!

Conversation

QuncCccccc commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

flutter-dashboard bot commented Aug 13, 2024

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc commented Aug 13, 2024 •

edited

Loading

QuncCccccc commented Aug 14, 2024 •

edited

Loading