-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Migration guide for M3 token update #11480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit b74eb2a): https://flutter-docs-prod--pr11480-token-update-breaking-chang-78jehnpj.web.app |
Landed in version: 3.26.0-0.0.pre<br> | ||
In stable release: not yet | ||
|
||
## References |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to include some API references like in other migration guides. ColorScheme, Theme, and Chip classes look relevant to include here.
Widgets that have been using these roles with their default value might look | ||
different. | ||
|
||
Additionally, the Material 3 tokens also updated the border color of Chips from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, the Material 3 tokens also updated the border color of Chips from | |
Additionally, the Material 3 tokens updated the border color of Chips from |
Additionally + also can be redundant, I do this all the time myself 😅
mode) to be more visually appealing while retaining accessible contrast. There | ||
are not any breakages identified in Flutter testing of this change, which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mode) to be more visually appealing while retaining accessible contrast. There | |
are not any breakages identified in Flutter testing of this change, which | |
mode) to be more visually appealing while retaining accessible contrast. | |
Testing identified this change as non-breaking in Flutter, but some customers | |
may notice this small change. |
Maybe we should also have non-breaking link to the breaking changes policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, replace "may" with might in line 13.
The Material Design tokens updated the mapping of 4 color roles (only in Light | ||
mode) to be more visually appealing while retaining accessible contrast. There | ||
are not any breakages identified in Flutter testing of this change, which | ||
applied to the following color properties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied to the following color properties: | |
The update affected the following color properties: |
|
||
## Migration guide | ||
|
||
The differences in the mappings of the color roles are small. Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The differences in the mappings of the color roles are small. Using | |
The differences in the mappings of the color roles are small. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all the suggestions!
Thanks for writing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kate did a great review! I'll lgtm this PR, but please make those changes and then you can land.
Is there a way to double check whether the links I provided work? Not very sure if I formatted them correctly. |
I think CI would fail if a link was broken. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is to add a breaking change page for the Material 3 token change in the material library(flutter/flutter#153722, flutter/flutter#153385).
Presubmit checklist