-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[webview_flutter_platform_interface][webview_flutter_wkwebview] Fix inconsistent imports #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wonder how that Dart code even compiled; it has an extra level of ../
unless I'm misreading it.
I think it's correct assuming |
But the file it's in is |
Ah, I see what you mean now. Just tested it and turns out that all of these are valid: import '../src/platform_navigation_delegate.dart';
import '../../src/platform_navigation_delegate.dart';
import '../../../src/platform_navigation_delegate.dart';
import '../../../../src/platform_navigation_delegate.dart';
import '../../../../../src/platform_navigation_delegate.dart'; |
This fails though: import '../../lib/src/platform_navigation_delegate.dart'; I think the compiler considers |
[webview_flutter_platform_interface][webview_flutter_wkwebview] Fix inconsistent imports
Pushing the plugin internally causes errors from these imports. This fixes them to follow the convention of all the other imports.
This is only changing imports so not tests and no version bump.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.