-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[file_selector] Remove uses of macUTIs
#3859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[file_selector] Remove uses of macUTIs
#3859
Conversation
Overriding version/changelog check: the tool is flagging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm.
You know far more about our first-party plugin versioning than I do, but given the API change, I'd have expected a major version bump, is that not the case here?
It's not actually the API change it looks like; when |
flutter/packages@de6131d...f163786 2023-05-01 [email protected] [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798) 2023-05-01 [email protected] Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) (flutter/packages#3874) 2023-05-01 [email protected] [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873) 2023-05-01 [email protected] [various] Speed up build-examples (flutter/packages#3849) 2023-05-01 [email protected] [file_selector] Remove uses of `macUTIs` (flutter/packages#3859) 2023-05-01 [email protected] [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
A change to replace `macUTIs` with `uniformTypeIdentifiers` (with `macUTIs` staying as an alias for compatibility) landed a while ago in the platform interface, but the rest of the packages were never updated to use it. This removes uses from all other packages, in preparation for formally deprecating `macUTIs`. Mostly completes flutter/flutter#103743
A change to replace
macUTIs
withuniformTypeIdentifiers
(withmacUTIs
staying as an alias for compatibility) landed a while ago in the platform interface, but the rest of the packages were never updated to use it. This removes uses from all other packages, in preparation for formally deprecatingmacUTIs
.Mostly completes flutter/flutter#103743
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.