Skip to content

[file_selector] Remove uses of macUTIs #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stuartmorgan-g
Copy link
Contributor

A change to replace macUTIs with uniformTypeIdentifiers (with macUTIs staying as an alias for compatibility) landed a while ago in the platform interface, but the rest of the packages were never updated to use it. This removes uses from all other packages, in preparation for formally deprecating macUTIs.

Mostly completes flutter/flutter#103743

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Copy link
Contributor Author

Overriding version/changelog check: the tool is flagging file_selector_web because I updated its pubspec.yaml to require a newer version of the platform interface, but that new version is only actually needed for the unit test, so it's not useful to release or mention.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels May 1, 2023
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm.

You know far more about our first-party plugin versioning than I do, but given the API change, I'd have expected a major version bump, is that not the case here?

@stuartmorgan-g
Copy link
Contributor Author

You know far more about our first-party plugin versioning than I do, but given the API change, I'd have expected a major version bump, is that not the case here?

It's not actually the API change it looks like; when uniformTypeIdentifiers was added, macUTIs just became an alias for it; see here and here. So this is just changing from a legacy name to a new name, but for the same actual property.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023
@auto-submit auto-submit bot merged commit 7d7ce03 into flutter:main May 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 2, 2023
flutter/packages@de6131d...f163786

2023-05-01 [email protected] [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798)
2023-05-01 [email protected] Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) (flutter/packages#3874)
2023-05-01 [email protected] [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873)
2023-05-01 [email protected] [various] Speed up build-examples (flutter/packages#3849)
2023-05-01 [email protected] [file_selector] Remove uses of `macUTIs` (flutter/packages#3859)
2023-05-01 [email protected] [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
A change to replace `macUTIs` with `uniformTypeIdentifiers` (with `macUTIs` staying as an alias for compatibility) landed a while ago in the platform interface, but the rest of the packages were never updated to use it. This removes uses from all other packages, in preparation for formally deprecating `macUTIs`.

Mostly completes flutter/flutter#103743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: file_selector platform-ios platform-linux platform-macos platform-web platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants