[pigeon]enable treat warning as errors for swift code in unit test #3889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this apply to ci? I would expect this to fail without any code changes. |
Not sure how CI runs our test. If it runs from Xcode (CMD+U), it should apply (@stuartmorgan probably knows?)
I fixed the warnings in the previous PR. |
|
stuartmorgan-g
approved these changes
May 2, 2023
hellohuanlin
added
the
autosubmit
tarrinneal
approved these changes
May 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2023
flutter/packages@f163786...407b7da 2023-05-03 [email protected] Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 [email protected] [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 [email protected] [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 [email protected] Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 [email protected] [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 [email protected] [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 [email protected] [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 [email protected] [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 [email protected] [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 [email protected] [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 [email protected] [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 [email protected] [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 [email protected] Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 3, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
May 4, 2023
…t test (#3901) `as [Any?]` here is actually not a "cast", but a "type annotation". An equivalent fix can be: ``` let arg: [Any?] = [nil] let inputEncoded = binaryMessenger.codec.encode(arg) ``` Fixes ``` heterogeneous collection literal could only be inferred to '[Any?]'; add explicit type annotation if this is intentional ``` Which was introduced in #3889 and later got reverted. See flutter/flutter#126006 for more details about some interesting research on this warning. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#126006 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
11 tasks
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…lutter#3889) This will make it easier to spot issues where we accidentally create an "implicit optional". For more details about why implicit optional is bad, see flutter#3658 For example, the following warning was ignored previously:  *List which issues are fixed by this PR. You must list at least one issue.* Mentioned in PR: flutter#3658 (comment) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
… test" (flutter#3898) Reverts flutter#3889 The tree is red on a warning in the test code, most likely new in the Xcode version that the tree was just updated to. Reverting so we can re-land this with a fix for the new warning.
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…t test (flutter#3901) `as [Any?]` here is actually not a "cast", but a "type annotation". An equivalent fix can be: ``` let arg: [Any?] = [nil] let inputEncoded = binaryMessenger.codec.encode(arg) ``` Fixes ``` heterogeneous collection literal could only be inferred to '[Any?]'; add explicit type annotation if this is intentional ``` Which was introduced in flutter#3889 and later got reverted. See flutter/flutter#126006 for more details about some interesting research on this warning. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#126006 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to spot issues where we accidentally create an "implicit optional". For more details about why implicit optional is bad, see #3658
For example, the following warning was ignored previously:
List which issues are fixed by this PR. You must list at least one issue.
Mentioned in PR: #3658 (comment)
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.