Revert "[pigeon]enable treat warning as errors for swift code in unit test" #3898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
May 3, 2023
stuartmorgan-g
added
emergency
auto-submit
bot
deleted the
revert-3889-pigeon_unit_test_treat_warning_as_errors
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 4, 2023
flutter/packages@407b7da...6bd59cd 2023-05-04 [email protected] [pigeon][reland]enable treat warnings as errors for swift code in unit test (flutter/packages#3901) 2023-05-04 [email protected] [video_player] Fix Android lints (flutter/packages#3886) 2023-05-04 [email protected] [quick_actions] Fix Android lint issues (flutter/packages#3885) 2023-05-03 [email protected] [camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format (flutter/packages#3277) 2023-05-03 [email protected] Revert "[pigeon]enable treat warning as errors for swift code in unit test" (flutter/packages#3898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
… test" (flutter#3898) Reverts flutter#3889 The tree is red on a warning in the test code, most likely new in the Xcode version that the tree was just updated to. Reverting so we can re-land this with a fix for the new warning.
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3889
The tree is red on a warning in the test code, most likely new in the Xcode version that the tree was just updated to. Reverting so we can re-land this with a fix for the new warning.