[ci] Remove unnecessary Linux libraries #3975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linux desktop template included some libraries as explicit dependencies unnecessarily, which were later removed from the template once we realized `snap` support didn't actually require them. This removes them from the Dockerfile, and from the CMakeLists.txt that still reference them. Fixes flutter/flutter#78562
stuartmorgan-g
added
the
override: no changelog needed
|
No changelog needed: cruft removal in example build files isn't relevant to clients. |
ditman
approved these changes
May 12, 2023
| @@ -23,7 +23,7 @@ RUN apt-get install -y clang-format | |||
| # - build tools. | |||
| RUN apt-get install -y clang cmake ninja-build file pkg-config | |||
| # - libraries. | |||
| RUN apt-get install -y libgtk-3-dev libblkid-dev liblzma-dev libgcrypt20-dev | |||
cbracken
approved these changes
May 12, 2023
|
The CI failure is just the OOB publishing failure that has the tree closed. |
tarrinneal
approved these changes
May 15, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 15, 2023
flutter/packages@6328cfb...6608b60 2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
flutter/packages@6328cfb...6608b60 2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
The Linux desktop template included some libraries as explicit dependencies unnecessarily, which were later removed from the template once we realized `snap` support didn't actually require them. This removes them from the Dockerfile, and from the CMakeLists.txt that still reference them. Fixes flutter/flutter#78562
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux desktop template included some libraries as explicit dependencies unnecessarily, which were later removed from the template once we realized
snapsupport didn't actually require them. This removes them from the Dockerfile, and from the CMakeLists.txt that still reference them.Fixes flutter/flutter#78562