[ci] Add a web version of Dart unit tests #4352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the new LUCI Dart unit tests, and removes the Cirrus version. Part of flutter/flutter#114373
stuartmorgan-g
requested review from
gspencergoog,
keyonghan,
chunhtai and
domesticmouse
as code owners
keyonghan
reviewed
Jun 30, 2023
.ci.yaml
Outdated
| @@ -93,48 +93,32 @@ targets: | |||
| version_file: flutter_master.version | |||
|
|
|||
| - name: Linux dart_unit_test_shard_1 master | |||
There was a problem hiding this comment.
Do you want to change the name to reflect web: Linux web_dart_unit_test_shard_1 master
There was a problem hiding this comment.
This was me hacking the web version into the existing config so I could run in CI without mucking around with led. The non-draft version once I have things passing will be new, bringup configs.
.ci.yaml
Outdated
| @@ -93,48 +93,32 @@ targets: | |||
| version_file: flutter_master.version | |||
|
|
|||
| - name: Linux dart_unit_test_shard_1 master | |||
| bringup: true # New target | |||
There was a problem hiding this comment.
As this seems a new target, shall we keep the bringup?
stuartmorgan-g
requested review from
jonahwilliams,
Hixie,
tarrinneal and
dnfield
as code owners
|
This is now ready for review. (Those of you who are incidentally pulled in because of minor changes to the package test configs are welcome to ignore this.) |
stuartmorgan-g
changed the title
tarrinneal
approved these changes
Jul 4, 2023
| @@ -185,7 +185,9 @@ void main() { | |||
|
|
|||
| expect((mip.toJson() as List<dynamic>)[2], 1); | |||
| expect((scaled.toJson() as List<dynamic>)[2], 3); | |||
| }); | |||
| }, | |||
| // TODO(stuartmorgan): Investigate timeout on web. | |||
There was a problem hiding this comment.
Does this need an issue?
There was a problem hiding this comment.
Based on a comment from David later I think we just need to change this to inline image data. I'll do a fast-follow on this.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 5, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 5, 2023
flutter/packages@a03b900...7042079 2023-07-05 [email protected] [ci] Add a web version of Dart unit tests (flutter/packages#4352) 2023-07-04 [email protected] Roll Flutter from aa5f4a2 to 590ef2d (5 revisions) (flutter/packages#4373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
stuartmorgan-g
added a commit
that referenced
this pull request
Jul 6, 2023
Enables the new LUCI Dart unit tests. There is no corresponding Cirrus removal because that test was accidentally removed early in #4352. Part of flutter/flutter#114373
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new LUCI targets in bringup mode to run all possible Dart unit tests in Chrome.
This is a new test (see linked issue), not a port of a Cirrus test, so it involves changes to tooling and packages:
dart_test.yamltest_ondirectives, to know when to skip.Most of flutter/flutter#128979