Skip to content

[ci] Enable LUCI Dart unit tests #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

Enables the new LUCI Dart unit tests.

There is no corresponding Cirrus removal because that test was accidentally removed early in #4352.

Part of flutter/flutter#114373

auto-submit bot pushed a commit that referenced this pull request Jul 6, 2023
Adds LUCI version of Linux custom package tests.

Removes the custom tests for `cross_file` and `google_identity_services_web` since they only existed to run unit tests in browser mode, which is [now standard for all packages that can be run that way](#4378).

Part of flutter/flutter#114373
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 771ec9b into flutter:main Jul 6, 2023
@stuartmorgan-g stuartmorgan-g deleted the luci-dart-unit branch July 6, 2023 14:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 6, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 6, 2023
flutter/packages@7042079...771ec9b

2023-07-06 [email protected] [ci] Enable LUCI Dart unit tests (flutter/packages#4378)
2023-07-06 [email protected] [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382)
2023-07-06 [email protected] [pigeon] adds generate option for example pigeons (flutter/packages#4370)
2023-07-06 [email protected] [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359)
2023-07-06 [email protected] [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289)
2023-07-06 [email protected] [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374)
2023-07-05 [email protected] Roll Flutter from 590ef2d to 35085c3 (3 revisions) (flutter/packages#4379)
2023-07-05 [email protected] [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337)
2023-07-05 [email protected] [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375)
2023-07-05 [email protected] [tools] Switch to `flutter test` (flutter/packages#4348)
2023-07-05 [email protected] [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants