[google_sign_in_web] Fixes force unwrap on values that can be null #4374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Thanks for the contribution! LGTM other than the version.
@ditman for secondary review.
ditman
approved these changes
Jul 5, 2023
Comment on lines
+53
to
+54
| const String minimalJwtToken = | ||
| 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.$minimalPayload.UTAe7dpdtFIMwsOqkZkjyjqyHnho5xHCcQylUFmOutM'; |
There was a problem hiding this comment.
Thanks for adding a test!
I'm glad you managed to create one of these, it's not a trivial process!
Comment on lines
-75
to
+76
| displayName: payload['name']! as String, | ||
| photoUrl: payload['picture']! as String, | ||
| displayName: payload['name'] as String?, | ||
| photoUrl: payload['picture'] as String?, |
There was a problem hiding this comment.
This makes total sense. Even the documentation of GoogleSignInUserData has the following comment on top of displayName and photoUrl:
/// Not guaranteed to be present for all users, even when configured.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 6, 2023
flutter/packages@7042079...771ec9b 2023-07-06 [email protected] [ci] Enable LUCI Dart unit tests (flutter/packages#4378) 2023-07-06 [email protected] [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382) 2023-07-06 [email protected] [pigeon] adds generate option for example pigeons (flutter/packages#4370) 2023-07-06 [email protected] [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315) 2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359) 2023-07-06 [email protected] [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289) 2023-07-06 [email protected] [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374) 2023-07-05 [email protected] Roll Flutter from 590ef2d to 35085c3 (3 revisions) (flutter/packages#4379) 2023-07-05 [email protected] [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337) 2023-07-05 [email protected] [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375) 2023-07-05 [email protected] [tools] Switch to `flutter test` (flutter/packages#4348) 2023-07-05 [email protected] [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Google Sign-in, the code uses two force unwraps on values (name and picture) that can be not present in the response. This cause an unhandled error that blocks sign-in.
Fixes flutter/flutter#130002 reported by me. The bug report describes how to get that error together with a screenshot of a given line.
My PR fixes that and add additional test for the future.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.