Skip to content

[pigeon] adds generate option for example pigeons #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2023
Merged

[pigeon] adds generate option for example pigeons #4370

merged 3 commits into from
Jul 6, 2023

Conversation

tarrinneal
Copy link
Contributor

Adds simple command for generating example files. Also adds arguments to choose what files to generate when running the generate function (test or example) runs both by default.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • [] I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tarrinneal
Copy link
Contributor Author

tarrinneal commented Jul 4, 2023 •
edited
Loading

@stuartmorgan have we been testing the tools for pigeon? I didn't see any - but I didn't look very hard either...

Also wasn't planning on a version bump for this, which could be wrong also...

@tarrinneal tarrinneal requested a review from stuartmorgan-g July 4, 2023 23:31
@stuartmorgan-g
Copy link
Contributor

@stuartmorgan have we been testing the tools for pigeon? I didn't see any - but I didn't look very hard either...

I guess we haven't. I'm not sure how testing things in tool works from an import-from-tests standpoint. If that's doable, it wouldn't hurt to test things, but since they are just for our own development use I'm not concerned about it either way. I'm not sure if there's an exemption category for this or not; you could ask in Discord.

Also wasn't planning on a version bump for this, which could be wrong also...

It's not wrong, the CI just errs on the side of flagging changes in example/ that it doesn't understand in case they are interesting to CHANGELOG. This doesn't need one.

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jul 5, 2023
stuartmorgan-g
stuartmorgan-g approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Jul 5, 2023

Is this code purely for our own internal use, generating PRs that are later reviewed? Or do end-users use it too?

@tarrinneal
Copy link
Contributor Author

Is this code purely for our own internal use, generating PRs that are later reviewed? Or do end-users use it too?

It's a quality of life improvement for generating files that are not used by end-users. Only contributors (and more realistically only me and Stuart)

@Hixie
Copy link
Contributor

Hixie commented Jul 5, 2023

test-exempt: affected output is covered by code review

@tarrinneal tarrinneal added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Jul 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 6, 2023

auto label is removed for flutter/packages, pr: 4370, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@auto-submit auto-submit bot merged commit f145bd6 into flutter:main Jul 6, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 6, 2023
@engine-flutter-autoroll
f145bd6 [pigeon] adds generate option for example pigeons (flutter/pa…
1b36108 
…ckages#4370)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 6, 2023
@engine-flutter-autoroll
Roll Packages from 7042079 to 771ec9b (12 revisions) (#130077)
7e2f1f5 
flutter/packages@7042079...771ec9b

2023-07-06 [email protected] [ci] Enable LUCI Dart unit tests (flutter/packages#4378)
2023-07-06 [email protected] [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382)
2023-07-06 [email protected] [pigeon] adds generate option for example pigeons (flutter/packages#4370)
2023-07-06 [email protected] [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359)
2023-07-06 [email protected] [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289)
2023-07-06 [email protected] [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374)
2023-07-05 [email protected] Roll Flutter from 590ef2d to 35085c3 (3 revisions) (flutter/packages#4379)
2023-07-05 [email protected] [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337)
2023-07-05 [email protected] [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375)
2023-07-05 [email protected] [tools] Switch to `flutter test` (flutter/packages#4348)
2023-07-05 [email protected] [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: pigeon platform-android platform-ios platform-macos platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarrinneal @stuartmorgan-g @Hixie