Skip to content

[go_router] Replaces uri related properties in GoRouterState #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2023
Merged

[go_router] Replaces uri related properties in GoRouterState #4392

merged 4 commits into from
Jul 21, 2023

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jul 6, 2023 •
edited
Loading

Replaces uri related field in GoRouterState, so that we don't need to mimic the API in uri. This also give developer the access to other field like http scheme(once supported) and fragment.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested review from johnpryan and hannah-hyj July 6, 2023 19:48
stuartmorgan-g
stuartmorgan-g reviewed Jul 6, 2023
View reviewed changes
stuartmorgan-g
stuartmorgan-g reviewed Jul 6, 2023
View reviewed changes
@chunhtai chunhtai changed the title [go_router] Revises breaking change policy and replaces propeties in GoRouterState [go_router] Replaces uri related properties in GoRouterState Jul 6, 2023
@chunhtai chunhtai mentioned this pull request Jul 21, 2023
Merged
3 tasks
hannah-hyj
hannah-hyj reviewed Jul 21, 2023
View reviewed changes
packages/go_router/README.md
@@ -36,7 +36,8 @@ See the API documentation for details on the following topics:
- [Named routes](https://pub.dev/documentation/go_router/latest/topics/Named%20routes-topic.html)
- [Error handling](https://pub.dev/documentation/go_router/latest/topics/Error%20handling-topic.html)

## Migration guides
## Migration Guides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link 404 not found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to wait for this pr flutter/website#9092

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr merged

parlough pushed a commit to flutter/website that referenced this pull request Jul 21, 2023
@chunhtai
Add go router v10 breaking changes link (#9092)
36ab502 
For breaking change flutter/packages#4392
hannah-hyj
hannah-hyj approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/go_router/lib/src/state.dart Outdated
extra,
error,
pageKey);
int get hashCode => Object.hash(uri, matchedLocation, name, path, fullPath,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: format

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2023
@auto-submit auto-submit bot merged commit 88a48ff into flutter:main Jul 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2023
@engine-flutter-autoroll
88a48ff [go_router] Replaces uri related properties in GoRouterState (f…
2ff849f 
…lutter/packages#4392)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2023
@engine-flutter-autoroll
88a48ff [go_router] Replaces uri related properties in GoRouterState (f…
0ca1889 
…lutter/packages#4392)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 24, 2023
@engine-flutter-autoroll
Roll Packages from 2266a76 to 8028caf (13 revisions) (#131196)
f2ba0a2 
flutter/packages@2266a76...8028caf

2023-07-24 [email protected] Roll Flutter from a8c8c55 to d7ed5dc (7 revisions) (flutter/packages#4556)
2023-07-23 [email protected] Roll Flutter from e8b397c to a8c8c55 (11 revisions) (flutter/packages#4552)
2023-07-22 [email protected] Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (flutter/packages#4550)
2023-07-21 [email protected] [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 [email protected] [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 [email protected] [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 [email protected] [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 [email protected] [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 [email protected] [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 [email protected] Roll Flutter from d07e8ae to 9cfbf6b (58 revisions) (flutter/packages#4544)
2023-07-21 [email protected] Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 [email protected] [go_router_builder] Removes `path_to_regexp` from the dependencies  (flutter/packages#4524)
2023-07-21 [email protected] [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter#131196)
5a67c44 
flutter/packages@2266a76...8028caf

2023-07-24 [email protected] Roll Flutter from a8c8c55 to d7ed5dc (7 revisions) (flutter/packages#4556)
2023-07-23 [email protected] Roll Flutter from e8b397c to a8c8c55 (11 revisions) (flutter/packages#4552)
2023-07-22 [email protected] Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (flutter/packages#4550)
2023-07-21 [email protected] [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 [email protected] [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 [email protected] [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 [email protected] [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 [email protected] [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 [email protected] [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 [email protected] Roll Flutter from d07e8ae to 9cfbf6b (58 revisions) (flutter/packages#4544)
2023-07-21 [email protected] Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 [email protected] [go_router_builder] Removes `path_to_regexp` from the dependencies  (flutter/packages#4524)
2023-07-21 [email protected] [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll @vashworth
Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter#131196)
b6cb814 
flutter/packages@2266a76...8028caf

2023-07-24 [email protected] Roll Flutter from a8c8c55 to d7ed5dc (7 revisions) (flutter/packages#4556)
2023-07-23 [email protected] Roll Flutter from e8b397c to a8c8c55 (11 revisions) (flutter/packages#4552)
2023-07-22 [email protected] Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (flutter/packages#4550)
2023-07-21 [email protected] [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 [email protected] [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 [email protected] [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 [email protected] [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 [email protected] [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 [email protected] [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 [email protected] Roll Flutter from d07e8ae to 9cfbf6b (58 revisions) (flutter/packages#4544)
2023-07-21 [email protected] Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 [email protected] [go_router_builder] Removes `path_to_regexp` from the dependencies  (flutter/packages#4524)
2023-07-21 [email protected] [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@hannah-hyj hannah-hyj hannah-hyj approved these changes

@johnpryan johnpryan Awaiting requested review from johnpryan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunhtai @stuartmorgan-g @hannah-hyj