Skip to content

[google_maps_flutter_web] Adds options for gesture handling and tilt controls. #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2023
Merged

[google_maps_flutter_web] Adds options for gesture handling and tilt controls. #4521

merged 5 commits into from
Jul 21, 2023

Conversation

Rexios80
Copy link
Member

See #3258

@Rexios80 Rexios80 requested a review from ditman as a code owner July 19, 2023 15:00
@Rexios80 Rexios80 mentioned this pull request Jul 19, 2023
Merged
11 tasks
@ditman ditman changed the title [google_maps_flutter_web] Web changes for #3258 [google_maps_flutter_web] Adds options for gesture handling and tilt controls. Jul 20, 2023
ditman
ditman approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stuartmorgan-g
stuartmorgan-g approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2023
@auto-submit auto-submit bot merged commit 203ad04 into flutter:main Jul 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2023
@engine-flutter-autoroll
203ad04 [google_maps_flutter_web] Adds options for gesture handling a…
6eefb64 
…nd tilt controls. (flutter/packages#4521)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2023
@engine-flutter-autoroll
203ad04 [google_maps_flutter_web] Adds options for gesture handling a…
41ec164 
…nd tilt controls. (flutter/packages#4521)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 24, 2023
@engine-flutter-autoroll
Roll Packages from 2266a76 to 8028caf (13 revisions) (#131196)
f2ba0a2 
flutter/packages@2266a76...8028caf

2023-07-24 [email protected] Roll Flutter from a8c8c55 to d7ed5dc (7 revisions) (flutter/packages#4556)
2023-07-23 [email protected] Roll Flutter from e8b397c to a8c8c55 (11 revisions) (flutter/packages#4552)
2023-07-22 [email protected] Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (flutter/packages#4550)
2023-07-21 [email protected] [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 [email protected] [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 [email protected] [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 [email protected] [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 [email protected] [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 [email protected] [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 [email protected] Roll Flutter from d07e8ae to 9cfbf6b (58 revisions) (flutter/packages#4544)
2023-07-21 [email protected] Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 [email protected] [go_router_builder] Removes `path_to_regexp` from the dependencies  (flutter/packages#4524)
2023-07-21 [email protected] [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter#131196)
5a67c44 
flutter/packages@2266a76...8028caf

2023-07-24 [email protected] Roll Flutter from a8c8c55 to d7ed5dc (7 revisions) (flutter/packages#4556)
2023-07-23 [email protected] Roll Flutter from e8b397c to a8c8c55 (11 revisions) (flutter/packages#4552)
2023-07-22 [email protected] Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (flutter/packages#4550)
2023-07-21 [email protected] [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 [email protected] [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 [email protected] [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 [email protected] [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 [email protected] [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 [email protected] [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 [email protected] Roll Flutter from d07e8ae to 9cfbf6b (58 revisions) (flutter/packages#4544)
2023-07-21 [email protected] Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 [email protected] [go_router_builder] Removes `path_to_regexp` from the dependencies  (flutter/packages#4524)
2023-07-21 [email protected] [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll @vashworth
Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter#131196)
b6cb814 
flutter/packages@2266a76...8028caf

2023-07-24 [email protected] Roll Flutter from a8c8c55 to d7ed5dc (7 revisions) (flutter/packages#4556)
2023-07-23 [email protected] Roll Flutter from e8b397c to a8c8c55 (11 revisions) (flutter/packages#4552)
2023-07-22 [email protected] Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (flutter/packages#4550)
2023-07-21 [email protected] [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 [email protected] [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 [email protected] [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 [email protected] [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 [email protected] [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 [email protected] [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 [email protected] Roll Flutter from d07e8ae to 9cfbf6b (58 revisions) (flutter/packages#4544)
2023-07-21 [email protected] Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 [email protected] [go_router_builder] Removes `path_to_regexp` from the dependencies  (flutter/packages#4524)
2023-07-21 [email protected] [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rexios80 @stuartmorgan-g @ditman