Fix popping repeated pages unexpectedly #4763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
approved these changes
Aug 28, 2023
| @@ -561,8 +562,8 @@ typedef _PageBuilderForAppType = Page<void> Function({ | |||
| class _PagePopContext { | |||
| _PagePopContext._(this.onPopPageWithRouteMatch); | |||
|
|
|||
| final Map<Page<dynamic>, RouteMatch> _routeMatchLookUp = | |||
| <Page<Object?>, RouteMatch>{}; | |||
| final Map<Page<dynamic>, List<RouteMatch>> _routeMatchesLookUp = | |||
There was a problem hiding this comment.
Can you add a comment why this can be a list? i.e. pushing const page.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2023
flutter/packages@383bffa...d7d3150 2023-08-29 [email protected] [rfw] Implement /* block comments */ in the text format (flutter/packages#4769) 2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.4 to 2.21.5 (flutter/packages#4810) 2023-08-28 [email protected] Roll Flutter from cd3aeef to ec387a4 (15 revisions) (flutter/packages#4807) 2023-08-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.0 to 1.9.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4798) 2023-08-28 [email protected] Fix popping repeated pages unexpectedly (flutter/packages#4763) 2023-08-28 [email protected] [pigeon] primitive enums (flutter/packages#4580) 2023-08-27 [email protected] Roll Flutter from 229b74d to cd3aeef (4 revisions) (flutter/packages#4777) 2023-08-26 [email protected] Roll Flutter from 61d9f55 to 229b74d (13 revisions) (flutter/packages#4776) 2023-08-25 [email protected] Roll Flutter from deeb811 to 61d9f55 (25 revisions) (flutter/packages#4774) 2023-08-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/packages#4770) 2023-08-24 [email protected] [css_colors] docs: Update deprecated link address (flutter/packages#4537) 2023-08-24 [email protected] Roll Flutter (stable) from efbf63d to e1e4722 (3 revisions) (flutter/packages#4767) 2023-08-24 [email protected] Roll Flutter from bd836cc to deeb811 (17 revisions) (flutter/packages#4766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:flutter/flutter#132229
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.