Skip to content

[rfw] Implement /* block comments */ in the text format #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 25, 2023

Also, fix the coverage which previously was not 100% anymore (mostly by making it possible to skip some lines because there's no way to track the coverage on the web side of things as far as I can tell).

Fixes flutter/flutter#133285

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Aug 25, 2023
@Hixie Hixie force-pushed the rfwbc branch 5 times, most recently from 482a8ff to 9e43d9a Compare August 25, 2023 10:11
Also, fix the coverage which previously was not 100% anymore (mostly by making it possible to skip some lines because there's no way to track the coverage on the web side of things as far as I can tell).
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@auto-submit auto-submit bot merged commit d7d3150 into flutter:main Aug 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 29, 2023
flutter/packages@383bffa...d7d3150

2023-08-29 [email protected] [rfw] Implement /* block comments */ in the text format (flutter/packages#4769)
2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.4 to 2.21.5 (flutter/packages#4810)
2023-08-28 [email protected] Roll Flutter from cd3aeef to ec387a4 (15 revisions) (flutter/packages#4807)
2023-08-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.0 to 1.9.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4798)
2023-08-28 [email protected] Fix  popping repeated pages unexpectedly (flutter/packages#4763)
2023-08-28 [email protected] [pigeon] primitive enums (flutter/packages#4580)
2023-08-27 [email protected] Roll Flutter from 229b74d to cd3aeef (4 revisions) (flutter/packages#4777)
2023-08-26 [email protected] Roll Flutter from 61d9f55 to 229b74d (13 revisions) (flutter/packages#4776)
2023-08-25 [email protected] Roll Flutter from deeb811 to 61d9f55 (25 revisions) (flutter/packages#4774)
2023-08-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/packages#4770)
2023-08-24 [email protected] [css_colors] docs: Update deprecated link address (flutter/packages#4537)
2023-08-24 [email protected] Roll Flutter (stable) from efbf63d to e1e4722 (3 revisions) (flutter/packages#4767)
2023-08-24 [email protected] Roll Flutter from bd836cc to deeb811 (17 revisions) (flutter/packages#4766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support block comments in RFW
2 participants