-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[url_launcher] Add an inAppBrowserView
mode in implementations
#5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 18 commits into
flutter:main
from
stuartmorgan-g:url-launcher-in-app-browser-implementantions
Oct 24, 2023
Merged
[url_launcher] Add an inAppBrowserView
mode in implementations
#5211
auto-submit
merged 18 commits into
flutter:main
from
stuartmorgan-g:url-launcher-in-app-browser-implementantions
Oct 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 50efebc.
(This is #5155 with the app-facing package reverted.) |
cbracken
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto label is removed for flutter/packages/5211, due to - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 25, 2023
flutter/packages@2faf992...f751ffb 2023-10-25 [email protected] [ci] Enable legacy Android emulator tests (flutter/packages#5190) 2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209) 2023-10-25 [email protected] Replace gems dependency with ruby. (flutter/packages#5219) 2023-10-25 [email protected] Update the ftl hardware version. (flutter/packages#5224) 2023-10-25 [email protected] [ci] Disable Windows Arm64 stable CI (flutter/packages#5217) 2023-10-24 [email protected] [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137) 2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155) 2023-10-24 [email protected] [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105) 2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211) 2023-10-24 [email protected] [ci] Fix legacy Android task names (flutter/packages#5191) 2023-10-24 [email protected] Update annotations deps to 1.7 (flutter/packages#4935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
federated: partial_changes
PR that contains changes for only a single package of a federated plugin change
p: url_launcher
platform-android
platform-ios
platform-linux
platform-macos
platform-web
platform-windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation package portion of #5155
This adds:
inAppBrowserView
launch mode which is distinct frominAppWebView
, so that use cases that require programatic close can specifically requestinAppWebView
instead.inAppBrowserView
since that gives better results in most cases.inAppBrowserView
will still automatically fall back toinAppBrowserView
in cases where it's not supported. (In the future, we might want to tune that based on feedback. We could instead have three modes: the webview-only mode we now have, the dynamic mode we now have iff the user requestedplatformDefault
, and a new Android Custom Tabs-only if it was explicitly requested which would fail if it doesn't work.)inAppBrowserView
as identical toinAppWebView
, since in practice that's what itsinAppWebView
mode has always been.supportsMode
andsupportsCloseForMode
support query methods.Fixes flutter/flutter#134208
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).