Skip to content

Update the ftl hardware version. #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

godofredoc
Copy link
Contributor

This is to unblock tests in packages timing out because of long queue times in ftl tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is to unblock tests in packages timing out because of long queue
times in ftl tests.
@godofredoc godofredoc requested a review from reidbaker October 24, 2023 23:43
@gmackall
Copy link
Member

gmackall commented Oct 24, 2023

Out of curiosity (because I changed this last), is there any more information available to us beyond the device capacity? These are both listed as "HIGH" capacity by firebase - is there any good way to know which of the two is actually higher capacity?
see below

@gmackall
Copy link
Member

gmackall commented Oct 24, 2023

Ouch, I see now - the capacity is per version and the version 33 category for oriole is actually LOW. Thanks for catching my mistake, LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2023
@auto-submit auto-submit bot merged commit afefb12 into flutter:main Oct 25, 2023
@godofredoc godofredoc deleted the update_ftl_version branch October 25, 2023 00:55
@reidbaker
Copy link
Contributor

@gmackall also godofredoc and I are in a chat with the firebase team and this was their suggestion.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 25, 2023
flutter/packages@2faf992...f751ffb

2023-10-25 [email protected] [ci] Enable legacy Android emulator tests (flutter/packages#5190)
2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209)
2023-10-25 [email protected] Replace gems dependency with ruby. (flutter/packages#5219)
2023-10-25 [email protected] Update the ftl hardware version. (flutter/packages#5224)
2023-10-25 [email protected] [ci] Disable Windows Arm64 stable CI (flutter/packages#5217)
2023-10-24 [email protected] [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137)
2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155)
2023-10-24 [email protected] [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105)
2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211)
2023-10-24 [email protected] [ci] Fix legacy Android task names (flutter/packages#5191)
2023-10-24 [email protected] Update annotations deps to 1.7 (flutter/packages#4935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Nov 2, 2023
Changes the FTL tests to use a high capacity device

Similar PR from packages repo: flutter/packages#5224

The list of devices (and their capacity) is visible through the [3rd option here "Google APIs Explorer"](https://firebase.google.com/docs/test-lab/android/available-testing-devices), without a login to any project.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
This is to unblock tests in packages timing out because of long queue times in ftl tests.
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants