Skip to content

[extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in … #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 15, 2023
Merged

[extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in … #5496

merged 9 commits into from
Dec 15, 2023

Conversation

mike-v2
Copy link
Contributor

@mike-v2 mike-v2 commented Nov 27, 2023 •
edited
Loading

…README

Updates the README to use a compiled excerpt source for its example of using google_sign_in plugin with the googleapis package.

Part of flutter/flutter#102679

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mike-v2 mike-v2 requested a review from ditman as a code owner November 27, 2023 22:17
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mike-v2
Copy link
Contributor Author

mike-v2 commented Nov 27, 2023

I wasn't sure if this code needs a test, since it's essentially just making an API call, and therefore the test would just be testing the mock?

@mike-v2
Copy link
Contributor Author

mike-v2 commented Nov 28, 2023

The failed check in Windows_x64 dart_unit_tests_shard_1 master seems to come from a failed unit test in packages/camera/camera_android_camerax, but I was unable to reproduce this locally.

tarrinneal
tarrinneal requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the new file you added is necessary. The former example is already in the example/lib/main file I believe. You should be able to just quote it from there (thus avoiding the need for tests and such for the new code).

@mike-v2 mike-v2 requested a review from tarrinneal December 8, 2023 05:15
@tarrinneal
Copy link
Contributor

There's a conflict that needs to be handled still @mike-v2

@tarrinneal
Copy link
Contributor

There's another one :(

stuartmorgan-g
stuartmorgan-g approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 15, 2023

auto label is removed for flutter/packages/5496, due to This PR has not met approval requirements for merging. Changes were requested by {tarrinneal}, please make the needed changes and resubmit this PR.
The PR author is not a member of flutter-hackers and needs 2 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 15, 2023

auto label is removed for flutter/packages/5496, due to This PR has not met approval requirements for merging. Changes were requested by {tarrinneal}, please make the needed changes and resubmit this PR.
The PR author is not a member of flutter-hackers and needs 2 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@stuartmorgan-g
Copy link
Contributor

@tarrinneal You have to approve it :)

@tarrinneal
Copy link
Contributor

@tarrinneal You have to approve it :)

I don't wanna

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit auto-submit bot merged commit eeb2c66 into flutter:main Dec 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
eeb2c66 [extension_google_sign_in_as_googleapis_auth] Adopt code exce…
cda0134 
…rpts in … (flutter/packages#5496)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
Roll Packages from 3f2e16b to d7dee79 (5 revisions) (#140322)
63753d4 
flutter/packages@3f2e16b...d7dee79

2023-12-16 [email protected] Remove flutter api named and optional parameters (flutter/packages#5689)
2023-12-15 [email protected] Manual roll Flutter (stable) from b0366e0 to 2e9cb0a (4 revisions) (flutter/packages#5692)
2023-12-15 [email protected] [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in â�¦ (flutter/packages#5496)
2023-12-15 [email protected] Roll Flutter from a51e33a to 2407f69 (30 revisions) (flutter/packages#5691)
2023-12-15 [email protected] [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
@engine-flutter-autoroll @CoderDake
Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter#140322)
d92edfa 
flutter/packages@3f2e16b...d7dee79

2023-12-16 [email protected] Remove flutter api named and optional parameters (flutter/packages#5689)
2023-12-15 [email protected] Manual roll Flutter (stable) from b0366e0 to 2e9cb0a (4 revisions) (flutter/packages#5692)
2023-12-15 [email protected] [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in â�¦ (flutter/packages#5496)
2023-12-15 [email protected] Roll Flutter from a51e33a to 2407f69 (30 revisions) (flutter/packages#5691)
2023-12-15 [email protected] [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@mike-v2 @arc-yong
[extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in … (
c629d99 
flutter#5496)

�README

Updates the README to use a compiled excerpt source for its example of using google_sign_in plugin with the `googleapis` package.

Part of [flutter/flutter#102679](flutter/flutter#102679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: extension_google_sign_in_as_googleapis_auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-v2 @tarrinneal @stuartmorgan-g