-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[google_sign_in_ios] Move pigeon as a dev dependency #5685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a style nit for the CHANGELOG.
Thanks for fixing this! I'm not sure how I did that in the first place.
@stuartmorgan I updated the changelog with the suggestion. |
Ugh, sorry about that. For some reason no matter how many times I change it, GitHub always wants to use my personal email address by default for changes I make via the UI, and I didn't notice. I think you will indeed have to force-push to erase that commit. So much for making my comment easier to apply... |
0adf814
to
fafd2be
Compare
fafd2be
to
90e4e47
Compare
@stuartmorgan Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could update the pigeon version. Probably not worth the effort.
flutter/packages@3f2e16b...d7dee79 2023-12-16 [email protected] Remove flutter api named and optional parameters (flutter/packages#5689) 2023-12-15 [email protected] Manual roll Flutter (stable) from b0366e0 to 2e9cb0a (4 revisions) (flutter/packages#5692) 2023-12-15 [email protected] [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in � (flutter/packages#5496) 2023-12-15 [email protected] Roll Flutter from a51e33a to 2407f69 (30 revisions) (flutter/packages#5691) 2023-12-15 [email protected] [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@3f2e16b...d7dee79 2023-12-16 [email protected] Remove flutter api named and optional parameters (flutter/packages#5689) 2023-12-15 [email protected] Manual roll Flutter (stable) from b0366e0 to 2e9cb0a (4 revisions) (flutter/packages#5692) 2023-12-15 [email protected] [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in � (flutter/packages#5496) 2023-12-15 [email protected] Roll Flutter from a51e33a to 2407f69 (30 revisions) (flutter/packages#5691) 2023-12-15 [email protected] [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes: flutter/flutter#140213
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.