-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[google_sign_in] Adopt code excerpts in README #5521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_sign_in] Adopt code excerpts in README #5521
Conversation
I was able to get the code excerpts from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor changes, thanks!
(Several of these are actually not very good code, like the global sign-in object, but not-great code that we know compiles is still an improvement!)
@@ -66,25 +66,32 @@ To use this plugin, follow the | |||
|
|||
Add the following import to your Dart code: | |||
|
|||
<?code-excerpt "example/lib/main.dart (Import)"?> | |||
```dart | |||
import 'package:google_sign_in/google_sign_in.dart'; | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just remove from 67 to here; this information is in the installation page instructions.
@@ -9,12 +9,15 @@ import 'dart:convert' show json; | |||
|
|||
import 'package:flutter/foundation.dart'; | |||
import 'package:flutter/material.dart'; | |||
// #docregion Import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And remove this.)
@@ -59,7 +63,9 @@ class _SignInDemoState extends State<SignInDemo> { | |||
bool isAuthorized = account != null; | |||
// However, in the web... | |||
if (kIsWeb && account != null) { | |||
// #docregion CanAccessScopes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this just above line 62 instead; it's all relevant to what the example is talking about.
isAuthorized = await _googleSignIn.canAccessScopes(scopes); | ||
// #enddocregion CanAccessScopes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then this will move down one line.
@tarrinneal for second review once the changes are made. |
Remove Import snippet since it's in the installation page instructions Expand CanAccessScopes snippet to include additional pertinent information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
auto label is removed for flutter/packages/5521, due to - The status or check suite Windows_x64 dart_unit_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto label is removed for flutter/packages/5521, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/packages/5521, due to - The status or check suite Linux dart_unit_test_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@b5958e2...1151191 2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674) 2023-12-13 [email protected] [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669) 2023-12-13 [email protected] [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567) 2023-12-13 [email protected] [google_sign_in] Update (web) example app. (flutter/packages#5634) 2023-12-13 [email protected] [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628) 2023-12-13 [email protected] [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660) 2023-12-13 [email protected] [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522) 2023-12-13 [email protected] [google_sign_in] Adopt code excerpts in README (flutter/packages#5521) 2023-12-13 [email protected] [css_colors] Adopt code excerpts in README (flutter/packages#5478) 2023-12-13 [email protected] [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Improves README example and updates it to use code excerpts.
Part of flutter/flutter#102679
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.