-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[path_provider] De-flake getExternalStorageDirectories test #5628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[path_provider] De-flake getExternalStorageDirectories test #5628
Conversation
…ider_test' into debugging_path_provider_test
That's super weird. Is there a Dart issue filed that we can reference in a comment? |
Filed dart-lang/sdk#54287 and added a comment |
@@ -117,6 +117,8 @@ void _verifySampleFile(Directory? directory, String name) { | |||
|
|||
file.writeAsStringSync('Hello world!'); | |||
expect(file.readAsStringSync(), 'Hello world!'); | |||
expect(directory.listSync(), isNotEmpty); | |||
// This check intentionally avoids using Directory.listSync due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the app-facing package we should probably make this codepath Android-only, and have other platforms keep using listSync
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once autoformat is happy.
I don't know why I assumed that was the changelog/version checker complaining 🤦. Thanks for taking another look, I'll fix that and then land |
Tree is blocked on two failures, one of which is this test failing (#5619 only disabled the test in Should this land on red to fix, or does the other blocker need to be resolved first? |
…5628) Fixes the flaky path provider test. Directories.listSync will sometimes not return the files in the directory (as discussed in flutter/flutter#139378), but the files are there and (after letting it loop for quite a while and comparing to current flake) they always appear in the output of `Process.runSync('ls', ...)`.
flutter/packages@b5958e2...1151191 2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674) 2023-12-13 [email protected] [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669) 2023-12-13 [email protected] [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567) 2023-12-13 [email protected] [google_sign_in] Update (web) example app. (flutter/packages#5634) 2023-12-13 [email protected] [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628) 2023-12-13 [email protected] [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660) 2023-12-13 [email protected] [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522) 2023-12-13 [email protected] [google_sign_in] Adopt code excerpts in README (flutter/packages#5521) 2023-12-13 [email protected] [css_colors] Adopt code excerpts in README (flutter/packages#5478) 2023-12-13 [email protected] [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…5668) Accidentally missed this in #5628 fixes flutter/flutter#139808
…5628) Fixes the flaky path provider test. Directories.listSync will sometimes not return the files in the directory (as discussed in flutter/flutter#139378), but the files are there and (after letting it loop for quite a while and comparing to current flake) they always appear in the output of `Process.runSync('ls', ...)`.
…lutter#5668) Accidentally missed this in flutter#5628 fixes flutter/flutter#139808
Fixes the flaky path provider test.
Directories.listSync will sometimes not return the files in the directory (as discussed in flutter/flutter#139378), but the files are there and (after letting it loop for quite a while and comparing to current flake) they always appear in the output of
Process.runSync('ls', ...)
.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.