Skip to content

[flutter_markdown] Allow for custom block element #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

dawidope
Copy link
Contributor

@dawidope dawidope commented Jan 6, 2024

Fixes problem with adding custom block syntax.

Issue: flutter/flutter#135848

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@dawidope
Copy link
Contributor Author

dawidope commented Feb 9, 2024

@domesticmouse is there any blocker to merge it?

@domesticmouse
Copy link
Contributor

PTAL @stuartmorgan

@tarrinneal tarrinneal self-requested a review March 19, 2024 16:22
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated my requests and merged upstream changes

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 19, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 19, 2024
Copy link
Contributor

auto-submit bot commented Mar 19, 2024

auto label is removed for flutter/packages/5815, due to - The status or check suite Linux analyze_legacy N-2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 19, 2024
@auto-submit auto-submit bot merged commit bb247f7 into flutter:main Mar 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 20, 2024
flutter/packages@a2f4ce0...23e56af

2024-03-19 [email protected] [camerax] Update README to encourage users to opt in (flutter/packages#6352)
2024-03-19 [email protected] [flutter_markdown] Allow for custom block element (flutter/packages#5815)
2024-03-19 [email protected] [pigeon] Adds Dart implementation of ProxyApi (flutter/packages#6043)
2024-03-19 [email protected] [camerax] Implements `setFocusMode` (flutter/packages#6176)
2024-03-19 [email protected] Roll Flutter from f217fc1 to d31a85b (23 revisions) (flutter/packages#6356)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mrares
Copy link

mrares commented Apr 22, 2024

@dawidope I'm very interested in this feature as well and I have a larger patch that also deals with nested blocks and inheriting styles from parent blocks, I'm interested in collaborating with you to upstream it if you're up for it.

arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants