-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camerax] Update README to encourage users to opt in #6352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -19,21 +20,17 @@ dependency in addition to `camera`: | |||
dependencies: | |||
# ...along with your other dependencies | |||
camera: ^0.10.4 | |||
camera_android_camerax: ^0.5.0 | |||
camera_android_camerax: ^0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will land after #6176 which will bump the plugin to version 0.6.0 as it has reached feature parity with camera_android.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternately, we could replace this whole section with something like "To use this plugin instead of camera_android
, run flutter pub add camera_android_camerax
in your project." That will give the latest version.
otherwise feel free to try out the current implementation and provide any | ||
feedback by filing issues under [`flutter/flutter`][5] with `[camerax]` in | ||
the title, which will be actively triaged. | ||
*Note*: This implementation will eventually become the default implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: should we be more prescriptive of when we estimate this becomes the default? eventually makes it still seem like it is far off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to "by May" to give us until I/O (though we should try making the breaking change well before then, at least a couple of weeks I'd say). LMK what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -19,21 +20,17 @@ dependency in addition to `camera`: | |||
dependencies: | |||
# ...along with your other dependencies | |||
camera: ^0.10.4 | |||
camera_android_camerax: ^0.5.0 | |||
camera_android_camerax: ^0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternately, we could replace this whole section with something like "To use this plugin instead of camera_android
, run flutter pub add camera_android_camerax
in your project." That will give the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@a2f4ce0...23e56af 2024-03-19 [email protected] [camerax] Update README to encourage users to opt in (flutter/packages#6352) 2024-03-19 [email protected] [flutter_markdown] Allow for custom block element (flutter/packages#5815) 2024-03-19 [email protected] [pigeon] Adds Dart implementation of ProxyApi (flutter/packages#6043) 2024-03-19 [email protected] [camerax] Implements `setFocusMode` (flutter/packages#6176) 2024-03-19 [email protected] Roll Flutter from f217fc1 to d31a85b (23 revisions) (flutter/packages#6356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Modify README to encourage users to opt into `camera_android_camerax` to start ramping up usage before changing it to the default plugin implementation on Android.
Modify README to encourage users to opt into
camera_android_camerax
to start ramping up usage before changing it to the default plugin implementation on Android.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).