Skip to content

[two_dimensional_scrollables] Fix TableView example #6154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

IchordeDionysos
Copy link
Contributor

TableView requires the cell to be wrapped in a TableViewCell. Simply returning any other widget will not work.

Not sure if we need a new release for this? Or if it's fine to be pushed with the next release?!

/cc @Piinks

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending a PR! I think this definitely warrants a release, poor docs are never helpful. :)

Can you update the pubspec and changelog with a minor version bump?

@Piinks Piinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Mar 7, 2024
@Piinks
Copy link
Contributor

Piinks commented Mar 7, 2024

Hey @IchordeDionysos, since we haven't heard back here, I included this fix in #6283.
Thanks very much for contributing, I am going to close this since it is resolved. :)

@Piinks Piinks closed this Mar 7, 2024
@IchordeDionysos IchordeDionysos deleted the patch-1 branch March 7, 2024 18:22
@IchordeDionysos
Copy link
Contributor Author

Hey @Piinks sorry this fell under the table :)
Thanks for adding it in your PR 👌

auto-submit bot pushed a commit that referenced this pull request Mar 7, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants