Skip to content

[two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells #6283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 7, 2024

Fixes flutter/flutter#144100
Picks up doc fix from #6154 as well

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added the p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package label Mar 7, 2024
@Piinks Piinks requested a review from goderbauer March 7, 2024 18:09
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -49,8 +49,10 @@ import 'table_span.dart';
/// ```dart
/// TableView.builder(
/// cellBuilder: (BuildContext context, TableVicinity vicinity) {
/// return Center(
/// child: Text('Cell ${vicinity.column} : ${vicinity.row}'),
/// return TableViewCell(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a way to analyze snippets in this repo, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware of. I searched the repo for cases of this but did not find any.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2024
@auto-submit auto-submit bot merged commit 0badb43 into flutter:main Mar 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 8, 2024
flutter/packages@6701c9e...0badb43

2024-03-07 [email protected] [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283)
2024-03-07 [email protected] Roll Flutter from 8f84f3f to 471a828 (27 revisions) (flutter/packages#6281)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[two_dimensional_scrollables] Merged cells is rendered in wrong position when pinned and scrolled
2 participants