-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells #6283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
unpinned merged cells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -49,8 +49,10 @@ import 'table_span.dart'; | |||
/// ```dart | |||
/// TableView.builder( | |||
/// cellBuilder: (BuildContext context, TableVicinity vicinity) { | |||
/// return Center( | |||
/// child: Text('Cell ${vicinity.column} : ${vicinity.row}'), | |||
/// return TableViewCell( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a way to analyze snippets in this repo, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I am aware of. I searched the repo for cases of this but did not find any.
…inned merged TableViewCells (flutter/packages#6283)
flutter/packages@6701c9e...0badb43 2024-03-07 [email protected] [two_dimensional_scrollables] Fix another combo of pinned/unpinned merged TableViewCells (flutter/packages#6283) 2024-03-07 [email protected] Roll Flutter from 8f84f3f to 471a828 (27 revisions) (flutter/packages#6281) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…rged TableViewCells (flutter#6283) Fixes flutter/flutter#144100 Picks up doc fix from flutter#6154 as well
Fixes flutter/flutter#144100
Picks up doc fix from #6154 as well
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.