Skip to content

[webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes #6378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2024

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Mar 23, 2024

This is a copy of #3278 since it doesn't allow for contributor access.

Fixes flutter/flutter#39502

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title add onHttpError [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes Mar 23, 2024
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review May 21, 2024 19:39
@stuartmorgan-g stuartmorgan-g self-requested a review May 21, 2024 19:39
@olsonm16
Copy link

Excited to see this merged -- I have a use-case for it!

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2024
@auto-submit auto-submit bot merged commit 40b66fc into flutter:main May 24, 2024
74 checks passed
@bparrishMines bparrishMines deleted the http_error_finish branch May 24, 2024 00:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 24, 2024
flutter/packages@1008d9e...7b423f5

2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782)
2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@1008d9e...7b423f5

2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782)
2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…catch HTTP error status codes (flutter#6378)

This is a copy of flutter#3278 since it doesn't allow for contributor access.

Fixes flutter/flutter#39502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Catch and handle all HTTP errors codes (eg 404) to redirect to a custom error page
3 participants