Skip to content

[ci] Start moving podspec check to ARM #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Now that google_maps_flutter supports ARM simulators, we should be able to move this task to ARM. This adds the ARM version in bringup mode, with a new name to reflect the fact that it is doing more that just checking podspecs now.

Once this propagates and is green, the x64 version will be removed.

Part of flutter/flutter#141493

Now that `google_maps_flutter` supports ARM simulators, we should be able to move this task to ARM. This adds the ARM version in bringup mode, with a new name to reflect the fact that it is doing more that just checking podspecs now.

Once this propagates and is green, the x64 version will be removed.

Part of flutter/flutter#141493
@stuartmorgan-g stuartmorgan-g requested a review from jmagman May 23, 2024 09:47
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2024
@auto-submit auto-submit bot merged commit 7b423f5 into main May 24, 2024
75 checks passed
@auto-submit auto-submit bot deleted the podspec-check-arm-part-1 branch May 24, 2024 02:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 24, 2024
flutter/packages@1008d9e...7b423f5

2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782)
2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this pull request May 24, 2024
Completes the switch of podspec checks to ARM, following up from
flutter#6782
- Brings the new target out of bringup mode.
- Removes the old target.
- Fixes the build ID of the swift-format CIPD package, since the
  previous one was copied from the other target, but the arm64 version
  of the package has a different build ID.

Fixes flutter/flutter#141493
auto-submit bot pushed a commit that referenced this pull request May 24, 2024
Completes the switch of podspec checks to ARM, following up from #6782
- Brings the new target out of bringup mode.
- Removes the old target.
- Fixes the build ID of the swift-format CIPD package, since the previous one was copied from the other target, but the arm64 version of the package has a different build ID.

Fixes flutter/flutter#141493
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@1008d9e...7b423f5

2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782)
2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Now that `google_maps_flutter` supports ARM simulators, we should be able to move this task to ARM. This adds the ARM version in bringup mode, with a new name to reflect the fact that it is doing more that just checking podspecs now.

Once this propagates and is green, the x64 version will be removed.

Part of flutter/flutter#141493
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Completes the switch of podspec checks to ARM, following up from flutter#6782
- Brings the new target out of bringup mode.
- Removes the old target.
- Fixes the build ID of the swift-format CIPD package, since the previous one was copied from the other target, but the arm64 version of the package has a different build ID.

Fixes flutter/flutter#141493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants