-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ci] Start moving podspec check to ARM #6782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `google_maps_flutter` supports ARM simulators, we should be able to move this task to ARM. This adds the ARM version in bringup mode, with a new name to reflect the fact that it is doing more that just checking podspecs now. Once this propagates and is green, the x64 version will be removed. Part of flutter/flutter#141493
jmagman
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 24, 2024
flutter/packages@1008d9e...7b423f5 2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782) 2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
stuartmorgan-g
added a commit
to stuartmorgan-g/packages
that referenced
this pull request
May 24, 2024
Completes the switch of podspec checks to ARM, following up from flutter#6782 - Brings the new target out of bringup mode. - Removes the old target. - Fixes the build ID of the swift-format CIPD package, since the previous one was copied from the other target, but the arm64 version of the package has a different build ID. Fixes flutter/flutter#141493
auto-submit bot
pushed a commit
that referenced
this pull request
May 24, 2024
Completes the switch of podspec checks to ARM, following up from #6782 - Brings the new target out of bringup mode. - Removes the old target. - Fixes the build ID of the swift-format CIPD package, since the previous one was copied from the other target, but the arm64 version of the package has a different build ID. Fixes flutter/flutter#141493
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@1008d9e...7b423f5 2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782) 2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Now that `google_maps_flutter` supports ARM simulators, we should be able to move this task to ARM. This adds the ARM version in bringup mode, with a new name to reflect the fact that it is doing more that just checking podspecs now. Once this propagates and is green, the x64 version will be removed. Part of flutter/flutter#141493
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Completes the switch of podspec checks to ARM, following up from flutter#6782 - Brings the new target out of bringup mode. - Removes the old target. - Fixes the build ID of the swift-format CIPD package, since the previous one was copied from the other target, but the arm64 version of the package has a different build ID. Fixes flutter/flutter#141493
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
google_maps_flutter
supports ARM simulators, we should be able to move this task to ARM. This adds the ARM version in bringup mode, with a new name to reflect the fact that it is doing more that just checking podspecs now.Once this propagates and is green, the x64 version will be removed.
Part of flutter/flutter#141493