[google_maps_flutter_web] Migrate to google_maps: 8.0.0

[Rexios80]

Migrates google_maps_flutter_web to google_maps: ^8.0.0

Blocked on the following:

• Fix issues with new js interop a14n/dart-google-maps#132
• [integration_test] Enable assertions when running with --wasm flutter#151426
• Fix flutter/packages tests that throw an error after test completion flutter#145149
• google_maps: 8.0.0 - TypeError: Cannot read properties of undefined (reading 'x') a14n/dart-google-maps#133
• [integration_test] flutter drive --wasm does not report results even though tests completed flutter#151561

Fixes flutter/flutter#148624

[Rexios80]

Why are the integration tests skipped? Is it because other steps are failing?

[stuartmorgan-g]

Why are the integration tests skipped? Is it because other steps are failing?

Because they are currently disabled

@ditman FYI in case you aren't aware; maybe something you could look at while gardening? @bparrishMines That's assigned to you, are you actively working on it? We shouldn't leave whole tests suites disabled for extended periods if we can avoid it.

[bparrishMines]

@stuartmorgan Yea im going to take a look into it now. I'll try to narrow down the specific test to skip, so we no longer skip all the integration tests.

[Rexios80]

@stuartmorgan is there an issue to track running integration tests compiled to WASM in CI?

[kevmoo]

you'll want to drop this override, I think

[Rexios80]

Definitely

[kevmoo]

We also likely DON'T want to publish this package depending on a pre-release package.

[Rexios80]

We also likely DON'T want to publish this package depending on a pre-release package.

Also definitely the case

[Rexios80]

Should we update the documentation with instructions on how to add that script locally for WASM compilation?

[ditman]

The overlays_test.dart also hangs for me when running with flutter_plugin_tools so I'm not sure how you got it to pass 🤔. Maybe I'm missing something?

@Rexios80 not sure! I'm running the tests in linux with your latest changes to the drive-examples tool and the latest changes in flutter/flutter so assertions work in wasm:

$ flutter --version
Flutter 3.24.0-1.0.pre.287 • channel master • [email protected]:ditman/flutter-flutter.git
Framework • revision 7b5462cc34 (21 hours ago) • 2024-07-25 15:22:05 -0700
Engine • revision d665bf82dc
Tools • Dart 3.6.0 (build 3.6.0-82.0.dev) • DevTools 2.37.1

I use flutter from git, so whenever I upgrade and expect changes in the tools I have a script to clear the fluter cache:

rm /work/flutter/flutter/bin/cache/flutter_tools.* ;
flutter --version ;

I can drive the example both with and without --wasm, and they pass in both cases!

In fact, if you can put it in an arbitrary location, the repo-root third-party directory would be ideal.

@stuartmorgan I'll try to move it to the existing third_party in the repo root, and maybe have a symlink to it from the test setup. The file needs to be served from fluter drive/flutter run; I'm not sure how the scripts will handle the symlink.

Should we update the documentation with instructions on how to add that script locally for WASM compilation?

@Rexios80 yes, we should mention that the file needs to be served from the same-domain or a CORP/COEP enabled CDN (which unpkg is not...)... Or find another CDN that does COEP/CORP (?)

[ditman]

Ended up swapping the CDN we use in the example/web/index.html to jsdelivr and that seems to support wasm, so no need to host the file in our repo!

dit@dit:example$ flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver test_driver/integration_test.dart --target integration_test/marker_clustering_test.dart --wasm
Resolving dependencies... 
Downloading packages... 
  _fe_analyzer_shared 72.0.0 (73.0.0 available)
  analyzer 6.7.0 (6.8.0 available)
  collection 1.18.0 (1.19.0 available)
! google_maps_flutter_web 0.5.9 from path .. (overridden)
  http_parser 4.0.2 (4.1.0 available)
  js 0.6.7 (0.7.1 available)
  material_color_utilities 0.11.1 (0.12.0 available)
  shelf 1.4.1 (1.4.2 available)
Got dependencies!
7 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Launching integration_test/marker_clustering_test.dart on Web Server in debug mode...
Compiling integration_test/marker_clustering_test.dart for the Web...        33.9s
✓ Built build/web
integration_test/marker_clustering_test.dart is being served at http://localhost:7357
The web-server device requires the Dart Debug Chrome extension for debugging. Consider using the Chrome or Edge
devices for an improved development workflow.
All tests passed.
Application finished.

(Also updated the README of the package to point to the jsdelivr URL)

[kevmoo]

@ditman I guess there's no way to avoid touching hosted resources for these tests...so 🤷

[Rexios80]

I'm running the tests in linux

I'm on macOS. Could that be the cause?

@ditman What do you think about the COEP error?

[ditman]

@ditman What do you think about the COEP error?

I've seen this issue now, thanks! I'm going to try and reconfigure the COEP/CORP headers that are sent back by the flutter tool to see if we can still get proper WasmGC but with a slightly more permissive credentialless header value.

(The error is unrelated to this PR, it's a "behavior" in the way that cross-origin isolation works with 3P resources :P)

---

PS: I've tested with this PR:

• [web] Set COEP:credentialless on flutter run/drive. flutter#152413

And the error seems to go away. I'm not an expert in Wasm, so we'll see what @eyebrowsoffire has to say about it!

[ditman]

Just bumped everything and this is looking good; if @Rexios80 is happy with the end result, let's merge! LGTM!

[Rexios80]

@ditman thanks for the help cleaning this up!

LGTM once checks pass

[kevmoo]

Can we mark this auto-submit?

[kevmoo]

[Rexios80]

@kevmoo Checks were being flakey but they finally passed so yes we can

[ditman]

Yeeeeah! Thanks for landing this! 🎉