-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ci] version_check_command now checks markdown of first CHANGELOG line. #7266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(It's cool that this PR found the same issue in another package) |
Use 'fixes a typo' instead of 'updates a typo'...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adding (PS: |
auto label is removed for flutter/packages/7266, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Please try again, my dear Mac_arm64 ios_platform_tests_shard_5 master bot! |
(Nah, flakes flaking, I'll try to land this later tonight when CI is better rested :/) |
auto label is removed for flutter/packages/7266, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Autosubmit bot, do your thang, all is 🟢 |
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR:
version_check_command
test so it checks the leading markdown of the first line of a CHANGELOG file, to ensure it's'##'
.Issues
Fixes flutter/flutter#152638
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.