Skip to content

[ci] version_check_command now checks markdown of first CHANGELOG line. #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

ditman
Copy link
Member

@ditman ditman commented Jul 31, 2024

This PR:

  • Modifies the version_check_command test so it checks the leading markdown of the first line of a CHANGELOG file, to ensure it's '##'.
  • Fixes the CHANGELOG in two packages that were allowed by the tool before this fix:
    • google_maps_flutter_web
    • interactive_media_ads

Issues

Fixes flutter/flutter#152638

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
Copy link
Member Author

ditman commented Jul 31, 2024

(It's cool that this PR found the same issue in another package)

Use 'fixes a typo' instead of 'updates a typo'...
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman
Copy link
Member Author

ditman commented Jul 31, 2024

Adding autosubmit to cheer up the pre-submit process :P

(PS: p: interactive_media_ads is not a label? /cc @stuartmorgan)

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
Copy link
Contributor

auto-submit bot commented Jul 31, 2024

auto label is removed for flutter/packages/7266, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@ditman
Copy link
Member Author

ditman commented Jul 31, 2024

Please try again, my dear Mac_arm64 ios_platform_tests_shard_5 master bot!

@ditman
Copy link
Member Author

ditman commented Jul 31, 2024

(Nah, flakes flaking, I'll try to land this later tonight when CI is better rested :/)

Copy link
Contributor

auto-submit bot commented Jul 31, 2024

auto label is removed for flutter/packages/7266, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2024
@ditman
Copy link
Member Author

ditman commented Aug 1, 2024

Autosubmit bot, do your thang, all is 🟢

@auto-submit auto-submit bot merged commit f8fbcdb into flutter:main Aug 1, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 1, 2024
flutter/packages@46a712f...27896d1

2024-08-01 [email protected] [local_auth_darwin] macOS Support  (flutter/packages#6267)
2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270)
2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266)
2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259)
2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232)
2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077)
2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@46a712f...27896d1

2024-08-01 [email protected] [local_auth_darwin] macOS Support  (flutter/packages#6267)
2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270)
2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266)
2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259)
2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232)
2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077)
2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@46a712f...27896d1

2024-08-01 [email protected] [local_auth_darwin] macOS Support  (flutter/packages#6267)
2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270)
2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266)
2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259)
2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232)
2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077)
2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[packages] [ci] Validation script allows wrong entry in CHANGELOG file.
2 participants