Roll to 9d5ede0f5, disabling impeller for google_maps_flutter_android #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
Aug 2, 2024
I really want to avoid going into the weekend with the roller still stuck and getting further and further behind, which is why I decided to do this now; I'm happy to revert this next week if we have a fix for the crash or if the engine disables impeller, but in the intervening time I can coax some rolls through the macOS flake. |
|
🤦🏻 This is the wrong command; FTL doesn't use command. I need to move this to the FTL side. |
reidbaker
approved these changes
Aug 2, 2024
tarrinneal
approved these changes
Aug 2, 2024
stuartmorgan-g
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: rolling dependencies and configuration change |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2024
flutter/packages@cc9ff47...82e8d1e 2024-08-04 [email protected] Manual roll Flutter from f10a497 to cbfb222 (23 revisions) (flutter/packages#7298) 2024-08-04 [email protected] [camera_avfoundation] dealloc camera on dispose (flutter/packages#7211) 2024-08-03 [email protected] Manual roll Flutter from 4ff9462 to f10a497 (22 revisions) (flutter/packages#7297) 2024-08-03 [email protected] Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter/packages#7296) 2024-08-03 [email protected] Manual roll Flutter from 9d5ede0 to 85960d2 (24 revisions) (flutter/packages#7295) 2024-08-02 [email protected] Roll to 9d5ede0, disabling impeller for google_maps_flutter_android (flutter/packages#7294) 2024-08-02 [email protected] [camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start (flutter/packages#7065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@cc9ff47...82e8d1e 2024-08-04 [email protected] Manual roll Flutter from f10a497 to cbfb222 (23 revisions) (flutter/packages#7298) 2024-08-04 [email protected] [camera_avfoundation] dealloc camera on dispose (flutter/packages#7211) 2024-08-03 [email protected] Manual roll Flutter from 4ff9462 to f10a497 (22 revisions) (flutter/packages#7297) 2024-08-03 [email protected] Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter/packages#7296) 2024-08-03 [email protected] Manual roll Flutter from 9d5ede0 to 85960d2 (24 revisions) (flutter/packages#7295) 2024-08-02 [email protected] Roll to 9d5ede0, disabling impeller for google_maps_flutter_android (flutter/packages#7294) 2024-08-02 [email protected] [camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start (flutter/packages#7065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@cc9ff47...82e8d1e 2024-08-04 [email protected] Manual roll Flutter from f10a497 to cbfb222 (23 revisions) (flutter/packages#7298) 2024-08-04 [email protected] [camera_avfoundation] dealloc camera on dispose (flutter/packages#7211) 2024-08-03 [email protected] Manual roll Flutter from 4ff9462 to f10a497 (22 revisions) (flutter/packages#7297) 2024-08-03 [email protected] Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter/packages#7296) 2024-08-03 [email protected] Manual roll Flutter from 9d5ede0 to 85960d2 (24 revisions) (flutter/packages#7295) 2024-08-02 [email protected] Roll to 9d5ede0, disabling impeller for google_maps_flutter_android (flutter/packages#7294) 2024-08-02 [email protected] [camera_avfoundation] fix stopVideoRecording waiting indefinitely and video lag at start (flutter/packages#7065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to unblock the flutter/flutter->flutter/packages roll, which is many days behind now, by turning off impeller in
google_maps_flutter_androidtemporarily until flutter/flutter#152691 is fixed, so that we can roll past the commit that enabled it by default.The alternative would be turn off device testing of
google_maps_flutter*, but we've never been able to turn that test on for emulators so that would remove allgoogle_maps_flutter*on Android, which is worse from the standpoint of things we need to test in this repo. There are a number of non-trivial changes happening to that package, so we need integration test coverage.