Skip to content

Roll to 9d5ede0f5, disabling impeller for google_maps_flutter_android #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Roll to 9d5ede0f5, disabling impeller for google_maps_flutter_android #7294

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a2e90e
Disable impeller on Android temporarily
stuartmorgan-g Aug 2, 2024
c365cbc
Manual roll
stuartmorgan-g Aug 2, 2024
8e61d9d
Revert incorrect tooling change
stuartmorgan-g Aug 2, 2024
b11dba7
Disable in example app metadata instead
stuartmorgan-g Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e2e43987c4fb5803c59d7ceb5048cf08bd22cffe
9d5ede0f5ae511cb3b2f6de2ab9164a428db418e
7 changes: 6 additions & 1 deletion script/tool/lib/src/drive_examples_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,12 @@ class DriveExamplesCommand extends PackageLoopingCommand {

_targetDeviceFlags = <String, List<String>>{
if (getBoolArg(platformAndroid))
platformAndroid: <String>['-d', androidDevice!],
platformAndroid: <String>[
'-d',
androidDevice!,
// Temporary workaround for https://github.com/flutter/flutter/issues/152691
'--no-enable-impeller',
],
if (getBoolArg(platformIOS)) platformIOS: <String>['-d', iOSDevice!],
if (getBoolArg(platformLinux)) platformLinux: <String>['-d', 'linux'],
if (getBoolArg(platformMacOS)) platformMacOS: <String>['-d', 'macos'],
Expand Down
2 changes: 2 additions & 0 deletions script/tool/test/drive_examples_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,7 @@ void main() {
'test',
'-d',
_fakeAndroidDevice,
'--no-enable-impeller',
'integration_test',
],
pluginExampleDirectory.path),
Expand Down Expand Up @@ -1069,6 +1070,7 @@ void main() {
'test',
'-d',
_fakeAndroidDevice,
'--no-enable-impeller',
'integration_test',
],
pluginExampleDirectory.path),
Expand Down