Skip to content

[web_benchmarks] Add flutter frame timings to benchmark metrics #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

kenzieschmoll
Copy link
Member

Work towards flutter/flutter#151551. I will follow on with a PR to add the percentile metrics (p50, p90, etc.).

@kenzieschmoll kenzieschmoll requested a review from yjbanov as a code owner October 1, 2024 19:53
@kenzieschmoll kenzieschmoll requested review from eyebrowsoffire and removed request for yjbanov October 1, 2024 19:53
@kenzieschmoll kenzieschmoll requested a review from yjbanov October 1, 2024 19:53
@kenzieschmoll kenzieschmoll merged commit 048ae84 into flutter:main Oct 1, 2024
76 checks passed
@kenzieschmoll kenzieschmoll deleted the flutterframes branch October 1, 2024 22:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2024
flutter/packages@ebcc4f0...7c97c88

2024-10-02 [email protected] [file_selector] Convert Linux to Pigeon (flutter/packages#7770)
2024-10-02 [email protected] Background/resuming `video_player` on Android sends one `initialized` event (flutter/packages#7722)
2024-10-02 [email protected] [quick_actions_android] Update instructions for using a launcher activity with more breadcrumbs (flutter/packages#7716)
2024-10-01 [email protected] Add flutter frame timings to benchmark metrics (flutter/packages#7759)
2024-10-01 [email protected] [local_auth] Update Pigeon in iOS and Android (flutter/packages#7724)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kenzieschmoll kenzieschmoll changed the title Add flutter frame timings to benchmark metrics [web_benchmarks] Add flutter frame timings to benchmark metrics Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants