[file_selector] Convert Linux to Pigeon #7770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cbracken
reviewed
Oct 2, 2024
| fl_value_append_take(image_group_extensions, fl_value_new_string("*.png")); | ||
| fl_value_append_take(image_group_extensions, fl_value_new_string("*.gif")); | ||
| fl_value_append_take(image_group_extensions, | ||
| fl_value_new_string("*.jgpeg")); |
cbracken
reviewed
Oct 2, 2024
packages/file_selector/file_selector_linux/linux/test/file_selector_plugin_test.cc
Outdated
Show resolved
Hide resolved
cbracken
approved these changes
Oct 2, 2024
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2024
flutter/packages@ebcc4f0...7c97c88 2024-10-02 [email protected] [file_selector] Convert Linux to Pigeon (flutter/packages#7770) 2024-10-02 [email protected] Background/resuming `video_player` on Android sends one `initialized` event (flutter/packages#7722) 2024-10-02 [email protected] [quick_actions_android] Update instructions for using a launcher activity with more breadcrumbs (flutter/packages#7716) 2024-10-01 [email protected] Add flutter frame timings to benchmark metrics (flutter/packages#7759) 2024-10-01 [email protected] [local_auth] Update Pigeon in iOS and Android (flutter/packages#7724) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| } | ||
| } | ||
|
|
||
| /// Options for GKT file chooser. |
There was a problem hiding this comment.
Doh! I'll try to remember to fix that next time we touch the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces manual method channel code with Pigeon.
I made a couple of simplifications to the Dart/C boundary while converting:
These changes are consistent with our general trend toward putting more logic in Dart and less in native code, for ease of maintenance.
Fixes flutter/flutter#117906
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).