[webview_flutter_wkwebview] Change callback methods with a non-null return type to non-null #8564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
bparrishMines
requested review from
stuartmorgan-g
and removed request for
cbracken
|
This is ready for review, but I won't land this until the pigeon update is made: #8567 |
| completion(.success(Void())) | ||
| } | ||
| } | ||
| print( |
There was a problem hiding this comment.
This codepath prints an error to the console but never calls completion, which seems like a bug. Doesn't the proxy API generator need to call completion(.failure(...)) in this path?
There was a problem hiding this comment.
Thats a really good catch. I'll add this fix to #8567. It looks like Kotlin needs this too.
stuartmorgan-g
approved these changes
Feb 11, 2025
| @@ -1,3 +1,8 @@ | |||
| ## 3.18.1 | |||
|
|
|||
| * Updates internal API wrapper to make all Flutter methods with a non-null return value be required | |||
There was a problem hiding this comment.
I would mention that this fixes a crash, since that's the client-visible effect of the change.
|
Does this not fix that crash? |
11 tasks
|
(It shouldn't delay this PR since we should get this fix out ASAP, but consider a follow-up that adds an integration test that would have hit this crash, so we have higher-level testing of the potential delegate states as well.) |
|
I'm not sure if it fixes the crash since I wasn't able to reproduce it. This should at least make it easier to debug since it will narrow down the cause. |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2025
…non-null return type to non-null (flutter/packages#8564)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2025
flutter/packages@625023a...8542af3 2025-02-15 [email protected] [various] Enable `permissive-` for Windows plugin examples (flutter/packages#8636) 2025-02-15 [email protected] [pigeon] Update task queue handling (flutter/packages#8627) 2025-02-14 [email protected] Update CODEOWNERS (flutter/packages#8628) 2025-02-14 [email protected] [flutter_adaptive_scaffold] Fix some memory leaks (flutter/packages#8546) 2025-02-14 [email protected] [camera] Fix crash when setting activeFormat on FLTCaptureDevice (flutter/packages#8630) 2025-02-13 [email protected] [camera] Remove remaining OCMock usage in tests (flutter/packages#8624) 2025-02-13 [email protected] [webview_flutter_wkwebview] Change callback methods with a non-null return type to non-null (flutter/packages#8564) 2025-02-12 [email protected] [google_sign_in_ios] Adds Swift Package Manager support (flutter/packages#7356) 2025-02-12 [email protected] [camera_avfoundation] Migrate tests to Swift - part 1 (flutter/packages#8603) 2025-02-12 [email protected] [video_player] Re-enables `asset videos live stream duration != 0` test for Android (flutter/packages#8610) 2025-02-12 [email protected] [go_router_builder] Add support for `TypedStatefulShellBranch`'s `preload` (flutter/packages#8587) 2025-02-12 [email protected] [local_auth_darwin] Fix test name for clarity (flutter/packages#8499) 2025-02-11 [email protected] [ci] Manually roll master, set -Xmx4G (flutter/packages#8586) 2025-02-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 4 directories with 1 update (flutter/packages#8551) 2025-02-10 [email protected] [pigeon] Add errors for ProxyAPI callback methods and null instances when reading in a ProxyApiBaseCodec (flutter/packages#8567) 2025-02-10 [email protected] [shared_preferences]Fix : SetState returning future (flutter/packages#8398) 2025-02-10 [email protected] [various] Add deprecation notices to READMEs (flutter/packages#8598) 2025-02-10 [email protected] [camera] Remove OCMock from CameraSettingsTests, CameraMethodChannelTests and CameraSessionPresetsTests (flutter/packages#8592) 2025-02-10 [email protected] [camera] Remove OCMock from FLTCamPhotoCaptureTests, FLTSavePhotoDelegateTests and StreamingTests (flutter/packages#8590) 2025-02-07 [email protected] [go_router] Add `preload` parameter to `StatefulShellBranchData.$branch` (flutter/packages#8545) 2025-02-07 [email protected] [video_player_avfoundation] iOS platform view support (flutter/packages#8237) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback methods that can't return nullable value are made non-null. If the error seen by issues listed below, this should make the failure happen in Dart.
Related:
flutter/flutter#162437
flutter/flutter#162368
Fixes flutter/flutter#125901
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.