[ci] Manually roll master, set -Xmx4G

[ditman]

Roll Flutter from 8e2a6fc to 892f9c1 (84 revisions)

flutter/flutter@8e2a6fc...892f9c1

Additional changes

• Sets -Xmx4G across the repo.

Issues

Completes: #8585

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[stuartmorgan-g]

LGTM with nit

[stuartmorgan-g]

Version/CHANGELOG override: false positive; change to non-example build.gradle files are in unit-test-specific sections.

[ditman]

This file is odd, it's not in an "example", and doesn't seem to be test related (?) Is this something that should be set in the build.gradle, instead of the gradle.properties?

[camsim99]

Looks like this was added in #3267 and it doesn't say why. I wonder if we even need it?

[LouiseHsu]

im this weeks gardener, hinging my bets on this pr to resolve the roll failures! Looks like Linux dart_unit_test_shard_1 master is failing consistently on a camera unit test and blocking this from merging:

00:19 +180 -1: /b/s/w/ir/x/w/packages/packages/camera/camera_android_camerax/test/recorder_test.dart: Recorder detached create does not call create on the Java side [E]                               
  PlatformException(channel-error, Unable to establish connection on channel., null, null)
  package:camera_android_camerax/src/camerax_library.g.dart 348:7                         JavaObjectHostApi.dispose
  ===== asynchronous gap ===========================
  dart:async                                                                              _CustomZone.registerUnaryCallback
  package:camera_android_camerax/src/camerax_library.g.dart 346:9                         JavaObjectHostApi.dispose
  package:camera_android_camerax/src/java_object.dart 38:33                               JavaObject._initInstanceManager.<fn>
  package:camera_android_camerax/src/instance_manager.dart 25:29                          new InstanceManager.<fn>
  ===== asynchronous gap ===========================
  dart:core                                                                               new _FinalizerImpl
  package:camera_android_camerax/src/instance_manager.dart 27:18                          new InstanceManager
  package:camera_android_camerax/src/java_object.dart 36:12                               JavaObject._initInstanceManager
  package:camera_android_camerax/src/java_object.dart 30:56                               JavaObject.globalInstanceManager
  package:camera_android_camerax/src/java_object.dart                                     JavaObject.globalInstanceManager
  package:camera_android_camerax/src/java_object.dart 75:57                               new JavaObjectFlutterApiImpl
  package:camera_android_camerax/src/android_camera_camerax_flutter_api_impls.dart 59:37  new AndroidCameraXCameraFlutterApis
  package:camera_android_camerax/src/android_camera_camerax_flutter_api_impls.dart 114:7  AndroidCameraXCameraFlutterApis.instance
  package:camera_android_camerax/src/android_camera_camerax_flutter_api_impls.dart        AndroidCameraXCameraFlutterApis.instance
  package:camera_android_camerax/src/recorder.dart 49:37                                  new Recorder.detached
  test/recorder_test.dart 41:16                                                           main.<fn>.<fn>
  
  This test failed after it had already completed.
  Make sure to use a matching library which informs the test runner
  of pending async work.

cc @camsim99 @bparrishMines for insights!

[camsim99]

cc @camsim99 @bparrishMines for insights!

@bparrishMines nothing related to this on the camera side appears to have been changed recently. Do you possibly know what could have triggered a change in results?

[ditman]

I cannot reliably reproduce the camerax failure in my local linux machine. It eventually fails if I run it multiple times, but in CI it seems that it fails always, firs try. I wonder if this has to do with running every other test suite alongside the camerax one (?)

I'm doing this from within the camerax dir:

$ clear && refresh-tools && flutter pub upgrade # Update flutter tool from git
$ for run in {1..10}; do flutter clean && flutter test; done # Run tests 10x

---

I tried to bisect this, but the test is flaky so my "good/bad" choices are probably wrong. Here's my log:

$ git bisect log
git bisect start
# status: waiting for both good and bad commits
# bad: [494c47cb4f98da6d6d903ce79dbb7c0325cdb777] Lower minimum java file count to 1. (#162915)
git bisect bad 494c47cb4f98da6d6d903ce79dbb7c0325cdb777
# status: waiting for good commit(s), bad commit known
# good: [6ea438f2965e94a3c515becd006f68967f132bb9] [Windows] Allow apps to prefer low power GPUs (#162490)
git bisect good 6ea438f2965e94a3c515becd006f68967f132bb9
# good: [5944d992ac403612c599d44b9a5eea62ce7ebc8a] Fix: Ensure CupertinoAlertDialog divider spans full width and resolve (#161490)
git bisect good 5944d992ac403612c599d44b9a5eea62ce7ebc8a
git bisect bad 0385ddc7eb3b0616a37777d5caf02f2c18af81e7
# bad: [db7e82bdfbac68ad82372edaad6505210885b4ca] chore(canvaskit): remove SurfaceFrame from Surface (#162825)
git bisect bad db7e82bdfbac68ad82372edaad6505210885b4ca
# good: [1b095a030d7037d9b3a31cad7b2149e368260991] [canvaskit] Resize to exactly the requested dimensions (#162708)
git bisect good 1b095a030d7037d9b3a31cad7b2149e368260991
# good: [1e035cc693f067ed5033f180e0b6169d2c8a3e58] Adjustments to FocusHighlightMode handling (#162417)
git bisect good 1e035cc693f067ed5033f180e0b6169d2c8a3e58
# good: [a6344bf2b36b36c6b0f5ded8d68ae5ae008e74cd] Changed docs for hintOverrides field of SemanticsProperties (#162632)
git bisect good a6344bf2b36b36c6b0f5ded8d68ae5ae008e74cd
# first bad commit: [db7e82bdfbac68ad82372edaad6505210885b4ca] chore(canvaskit): remove SurfaceFrame from Surface (#162825)
# good: [db7e82bdfbac68ad82372edaad6505210885b4ca] chore(canvaskit): remove SurfaceFrame from Surface (#162825)
git bisect good db7e82bdfbac68ad82372edaad6505210885b4ca

It seems that from # bad: [0385ddc7eb3b0616a37777d5caf02f2c18af81e7] Roll Packages from e6ce02c2a859 to 625023aa0376 (4 revisions) (#162878) it might be getting "worse" but it's hard to say.

---

The flake seems to be: Recorder detached create does not call create on the Java side [E], but I'm not sure if it's flagging a breakage, or the test is being naughty.