[camera_avfoundation] Migrate tests to Swift - part 2 #8613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39334e1.
FirentisTFW
commented
Feb 13, 2025
Comment on lines
90
to
96
| // AVAssetWriterInput needs these three keys, otherwise it throws. | ||
| var outputSettingsWithRequiredKeys = outputSettings ?? [:] | ||
| outputSettingsWithRequiredKeys[AVVideoCodecKey] = AVVideoCodecType.h264 | ||
| outputSettingsWithRequiredKeys[AVVideoWidthKey] = 1280 | ||
| outputSettingsWithRequiredKeys[AVVideoHeightKey] = 720 | ||
|
|
||
| return AVAssetWriterInput(mediaType: .video, outputSettings: outputSettingsWithRequiredKeys) |
There was a problem hiding this comment.
In Objective-C it worked without these three keys, although the documentation still says that they're needed. For Swift, I had to add them here, otherwise AVAssetWriterInput constructor throws, as per the documentation:
When using this initializer, a video settings dictionary must be fully specified, meaning that it must contain AVVideoCodecKey, AVVideoWidthKey, and AVVideoHeightKey.
and
This method throws an exception for any of the following reasons:
...
- for video inputs, the output settings do not contain a required key (AVVideoCodecKey, AVVideoWidthKey, AVVideoHeightKey)
And in this test we only have AVVideoCompressionPropertiesKey in options here.
FirentisTFW
force-pushed
the
feature/camera-swift-test-migration-part2
branch
from
3227f58 to
612c425
Compare
hellohuanlin
approved these changes
Feb 13, 2025
...amera_avfoundation/example/ios/RunnerTests/CameraCaptureSessionQueueRaceConditionTests.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraOrientationTests.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraOrientationTests.swift
Outdated
Show resolved
Hide resolved
FirentisTFW
commented
Feb 13, 2025
There was a problem hiding this comment.
This file was migrated to Swift in the previous PR, but I did not remove the ObjectiveC version - now it's done.
|
@stuartmorgan Would you like to do a secondary review or can I land it? |
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraExposureTests.m
Show resolved
Hide resolved
|
I only skimmed it, since it doesn't need a second full review, but other than the missing test file this looks good to land. |
FirentisTFW
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2025
flutter/packages@8542af3...cb4fb13 2025-02-18 [email protected] [shared_preferences] Fix JSON parsing issue with _decodeValue (flutter/packages#8211) 2025-02-18 [email protected] [camera_avfoundation] Migrate tests to Swift - part 2 (flutter/packages#8613) 2025-02-18 [email protected] [google_sign_in] Adopt task queues for Android (flutter/packages#8622) 2025-02-17 [email protected] Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (flutter/packages#8614) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates some of Objective-C tests to Swift as a part of Swift migration: flutter/flutter/issues/119109.
I kept the names of test cases the same.
Tests migrated in this PR:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).