Skip to content

[google_sign_in] Adopt task queues for Android #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Replaces manual offloading of some method implementations to a
background task queue with just using the new method channel task queue
system to have those methods be called on a background queue
automatically.

This simplifies the code, and also allows removing the Guava dependency with
a couple of other minor changes:

  • Replaces Joiner with Java 8's String.join.
  • Replaces Strings.isEmptyOrNull with a local helper method.

Fixes flutter/flutter#13991

Pre-launch Checklist

Replaces manual offloading of some method implementations to a
background task queue with just using the new method channel task queue
system to have those methods be called on a background queue
automatically.

This simplifies the code, and also allows removing the Guava dependency.

Fixes flutter/flutter#13991
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g stuartmorgan-g changed the title Google sign in android taskqueue [google_sign_in] Adopt task queues for Android Feb 13, 2025
@stuartmorgan-g
Copy link
Contributor Author

Some of this code may go away anyway in the conversion to Credential Manager, but I wanted to split out this cleanup to simplify future changes.

@stuartmorgan-g
Copy link
Contributor Author

test-exempt: code refactor with no semantic change

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2025
@auto-submit auto-submit bot merged commit f6b2266 into flutter:main Feb 18, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 18, 2025
flutter/packages@8542af3...cb4fb13

2025-02-18 [email protected]
[shared_preferences] Fix JSON parsing issue with _decodeValue
(flutter/packages#8211)
2025-02-18 [email protected] [camera_avfoundation] Migrate
tests to Swift - part 2 (flutter/packages#8613)
2025-02-18 [email protected] [google_sign_in] Adopt task queues
for Android (flutter/packages#8622)
2025-02-17 [email protected] Roll Flutter from
892f9c1 to e8f34a9 (71 revisions) (flutter/packages#8614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[google_sign_in] Remove guava dependency
2 participants