[camera_avfoundation] Tests backfilling - part 1 #8698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertOdrowaz
force-pushed
the
feature/camera-tests-backfilling
branch
2 times, most recently
from
cead82f to
1ad685d
Compare
packages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
Outdated
Show resolved
Hide resolved
...s/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginForwardingMethodTests.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-tests-backfilling
branch
from
1ad685d to
72edba6
Compare
|
@hellohuanlin thanks for the review. I extracted the forwarding method tests from this PR and resolved most of the comments |
hellohuanlin
reviewed
Mar 3, 2025
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
Outdated
Show resolved
Hide resolved
hellohuanlin
reviewed
Mar 3, 2025
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift
Show resolved
Hide resolved
hellohuanlin
reviewed
Mar 3, 2025
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockFLTCam.swift
Show resolved
Hide resolved
hellohuanlin
reviewed
Mar 3, 2025
...amera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockFLTCameraPermissionManager.swift
Show resolved
Hide resolved
hellohuanlin
approved these changes
Mar 4, 2025
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2025
flutter/packages@9e4684e...abba683 2025-03-05 [email protected] [camera_avfoundation] Tests backfilling - part 1 (flutter/packages#8698) 2025-03-04 [email protected] [go_router_builder]: Fix `The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737) 2025-03-04 [email protected] [video_player_android] Platform view support (flutter/packages#8466) 2025-03-04 [email protected] [webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request` (flutter/packages#8766) 2025-03-03 [email protected] Manual roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8775) 2025-03-03 [email protected] Roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8774) 2025-03-03 [email protected] [flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (flutter/packages#8760) 2025-03-03 [email protected] [google_sign_in] Add Android account name field as optional (platform interface changes) (flutter/packages#8735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backfills tests for the
CameraPluginclass as part of flutter/flutter#119109There are 3 new test files:
createCamera(withName)methodinitializeCameramethodCameraPluginForwardingMethodTests contains tests for all methods that only forward to theextracted to separate PRFLTCaminstance without any (or almost any forstartVideoRecording) logicI've also added
minimumExposureOffsetandmaximumExposureOffsettoFLTCamto make both easier to mock and more consistent. Before theCameraPluginclass used theCaptureDevicemethods directly by accessing thecaptureDevicefield of theFLTCamclass.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.