[go_router_builder]: Fix The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' on path and query params
#8737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaoGiaHieu-dev
changed the title
CaoGiaHieu-dev
changed the title
The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' on path and query params
Karibash
reviewed
Feb 28, 2025
| @@ -155,7 +155,7 @@ extension $HotdogRouteWithEverythingExtension on HotdogRouteWithEverything { | |||
| static HotdogRouteWithEverything _fromState(GoRouterState state) => | |||
| HotdogRouteWithEverything( | |||
| _$boolConverter(state.pathParameters['ketchup']!)!, | |||
| state.uri.queryParameters['mustard'], | |||
| state.uri.queryParameters['mustard']!, | |||
There was a problem hiding this comment.
Since mustard is optional, I believe it should not be asserted as non-null.
This issue is caused by the fact that the _stateValueAccess function uses element.isRequired as the condition for non-null assertion.
As in the PR I submitted, the condition should be !element.type.isNullableType && !element.hasDefaultValue.
There was a problem hiding this comment.
@Karibash you right . im gonna update this . thanks for your comment
Closed
11 tasks
chunhtai
approved these changes
Mar 3, 2025
Co-authored-by: chunhtai <[email protected]>
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2025
… be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2025
flutter/packages@9e4684e...abba683 2025-03-05 [email protected] [camera_avfoundation] Tests backfilling - part 1 (flutter/packages#8698) 2025-03-04 [email protected] [go_router_builder]: Fix `The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737) 2025-03-04 [email protected] [video_player_android] Platform view support (flutter/packages#8466) 2025-03-04 [email protected] [webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request` (flutter/packages#8766) 2025-03-03 [email protected] Manual roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8775) 2025-03-03 [email protected] Roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8774) 2025-03-03 [email protected] [flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (flutter/packages#8760) 2025-03-03 [email protected] [google_sign_in] Add Android account name field as optional (platform interface changes) (flutter/packages#8735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact of this pr #8405 , params with required enum cannot parse
Fixed : flutter/flutter#164354
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.