Skip to content

[go_router_builder]: Fix The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' on path and query params #8737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 4, 2025

Conversation

CaoGiaHieu-dev
Copy link
Contributor

@CaoGiaHieu-dev CaoGiaHieu-dev commented Feb 28, 2025

Impact of this pr #8405 , params with required enum cannot parse

Fixed : flutter/flutter#164354

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@CaoGiaHieu-dev CaoGiaHieu-dev changed the title [go_router_builder]: allow nullable String where try parse to enum [go_router_builder]: allow nullable String when try parse to enum Feb 28, 2025
@CaoGiaHieu-dev CaoGiaHieu-dev changed the title [go_router_builder]: allow nullable String when try parse to enum [go_router_builder]: Fix The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' on path and query params Feb 28, 2025
@@ -155,7 +155,7 @@ extension $HotdogRouteWithEverythingExtension on HotdogRouteWithEverything {
static HotdogRouteWithEverything _fromState(GoRouterState state) =>
HotdogRouteWithEverything(
_$boolConverter(state.pathParameters['ketchup']!)!,
state.uri.queryParameters['mustard'],
state.uri.queryParameters['mustard']!,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since mustard is optional, I believe it should not be asserted as non-null.
This issue is caused by the fact that the _stateValueAccess function uses element.isRequired as the condition for non-null assertion.
As in the PR I submitted, the condition should be !element.type.isNullableType && !element.hasDefaultValue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karibash you right . im gonna update this . thanks for your comment

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment

@chunhtai chunhtai requested review from hannah-hyj and removed request for Karibash March 3, 2025 19:33
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submit auto-submit bot merged commit f246137 into flutter:main Mar 4, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2025
… be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 5, 2025
flutter/packages@9e4684e...abba683

2025-03-05 [email protected] [camera_avfoundation] Tests
backfilling - part 1 (flutter/packages#8698)
2025-03-04 [email protected]
[go_router_builder]: Fix `The argument type 'String?' can't be assigned
to the parameter type 'String' because 'String?' ` on path and query
params (flutter/packages#8737)
2025-03-04 [email protected] [video_player_android] Platform
view support (flutter/packages#8466)
2025-03-04 [email protected]
[webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request`
(flutter/packages#8766)
2025-03-03 [email protected] Manual roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8775)
2025-03-03 [email protected] Roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8774)
2025-03-03 [email protected] [flutter_plugin_android_lifecycle] Uses
flutter.compileSdkVersion, bumps minimum flutter version to 3.27
(flutter/packages#8760)
2025-03-03 [email protected] [google_sign_in] Add Android account name
field as optional (platform interface changes) (flutter/packages#8735)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router_builder]: After mirgate to version 2.8.1 , the queryParams with required enum cause error
4 participants