Skip to content

[flutter_plugin_android_lifecycle] Removes flutter.compileSdkVersion for 35 to support flutter versions prior to 3.27 #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

reidbaker
Copy link
Contributor

Fixes #flutter/flutter/issues/164362
Functionally a revert of #8700 which found out what would break.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

…for 35 to support flutter versions prior to 3.27
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Very good call on doing a single test plugin first!

We could add a check for this to gradle-check when doing the "re-land" if you think it's worthwhile.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025
Copy link
Contributor

auto-submit bot commented Feb 28, 2025

auto label is removed for flutter/packages/8758, Failed to merge flutter/packages/8758 with Pull request flutter/packages/8758 could not be merged: Pull Request is still a draft.

@reidbaker reidbaker marked this pull request as ready for review February 28, 2025 15:48
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025
@auto-submit auto-submit bot merged commit bf5e9e7 into flutter:main Feb 28, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2025
…dkVersion for 35 to support flutter versions prior to 3.27 (flutter/packages#8758)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 3, 2025
flutter/packages@70b41e1...9e4684e

2025-03-02 [email protected] Roll Flutter from
2e570ca to 842db35 (59 revisions) (flutter/packages#8771)
2025-02-28 [email protected] [tool] Validate gradle compileSdk
(flutter/packages#8761)
2025-02-28 [email protected] [video_player] Disable flaky
`testAudioOnlyHLSControls` (flutter/packages#8757)
2025-02-28 [email protected] [flutter_plugin_android_lifecycle]
Removes flutter.compileSdkVersion for 35 to support flutter versions
prior to 3.27 (flutter/packages#8758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Mar 3, 2025
…mps minimum flutter version to 3.27 (#8760)

- **[flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (first version to have support)**
related to flutter/flutter/issues/149836 
Functionally a reland of #8700 after the "revert" in #8758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_plugin_android_lifecycle platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants