[tool] Validate gradle compileSdk #8761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that plugins use `compileSdk` rather than the deprecated `compileSdkVersion`, and that if they set it to `flutter.compileSdkVersion` they require at least Flutter 3.27. Would have prevented flutter/flutter#164362
11 tasks
In addition to the unit tests, I ran this locally against the tree at the commit before bf5e9e7 and verified that it did indeed fail on that plugin. |
reidbaker
approved these changes
Feb 28, 2025
stuartmorgan-g
added
the
autosubmit
stuartmorgan-g
deleted the
tool-check-flutter-compilesdkversion-usage
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 3, 2025
flutter/packages@70b41e1...9e4684e 2025-03-02 [email protected] Roll Flutter from 2e570ca to 842db35 (59 revisions) (flutter/packages#8771) 2025-02-28 [email protected] [tool] Validate gradle compileSdk (flutter/packages#8761) 2025-02-28 [email protected] [video_player] Disable flaky `testAudioOnlyHLSControls` (flutter/packages#8757) 2025-02-28 [email protected] [flutter_plugin_android_lifecycle] Removes flutter.compileSdkVersion for 35 to support flutter versions prior to 3.27 (flutter/packages#8758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that plugins use
compileSdkrather than the deprecatedcompileSdkVersion, and that if they set it toflutter.compileSdkVersionthey require at least Flutter 3.27.Would have prevented flutter/flutter#164362