[video_player] Add option to set video audio to mix mode in iOS

[wwwdata]

When listening to music in iOS, the Video Playback would disable the music and only the audio from the Video is enabled. For most use cases that should be OK but when playing videos in the background that are silent, that is not a desirable behaviour.

I also noticed a lot of errors because the initializingCompleter was called even though it was already completed so I added a guard against that.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[wwwdata]

I signed it!

[googlebot]

CLAs look good, thanks!

[eopeter]

Any word on moving this pull request forward?

[wwwdata]

hm, I can fix the linter errors and rebase but I would appreciate some feedback from the maintainers if this is a good approach or what they think about it in general.

[cyanglaz]

Thank you for the contribution, It looks good overall. I left some comments.

Also, I think we should try to combine this PR with #1755 so we can easily unify the public API.

[wwwdata]

Hi, thanks for the review. I will make the requested changes now and make the build green. I would suggest that I merge changes from #1755 (as one commit into this branch) and also set the correct mode for Android when the configuration option was provided to mix the audio. Is this ok for you @recastrodiaz ?

[recastrodiaz]

Hi @wwwdata Feel free to merge the code in #1755, or even just copy paste the changes into you branch. (The other PR is basically a one liner change).

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[wwwdata]

@recastrodiaz pulled the one commit from you. I guess you have to tell the googlebot again that you consent, like explained in it's comment?

Android is now also using the option, tested in in emulator, worked fine for me. Now I will check that all builds get green.

[recastrodiaz]

@googlebot I consent

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[wwwdata]

ok, @cbenhagen I will rebase and adopt this when I have time.

[wwwdata]

I adapted it to the new structure but I am not sure how to make the tests pass because I had to make a change in the interface package and in the player package and they depend on each other but the new one is not released... In general, this structure is very complicated in my opinion.

So the reason to split this up is just that the web plugin does not install the ios and android dependencies?

Feel free to change whatever is necessary in order to merge it.

[sanekyy]

Hello @wwwdata.

So the reason to split this up is just that the web plugin does not install the ios and android dependencies?

You can read about the reason here.

[crazedVic]

anyone that runs into this... like us for instance, we have an app that doesn't use sound but we have video backgrounds, calling play on VideoController was killing user's background music playing on ios.

fix is here for those desperate: https://github.com/crazedVic/plugins

[wwwdata]

@crazedVic if you want to take this topic over, go ahead and open a PR with your fixes. Link it here so we now that you took over then I gladly close my PR. For me, this is just a way too long ongoing process right now and I don't have time for this issue anymore.

[crazedVic]

@wwwdata To be honest, I think this oversight is a bug and something that Google should have fixed on their own instead of making someone trying to help (in this case, you) jump through all these hoops. If there's nobody on their team willing to take the time to fix their own product (or keep it updated, this is the only plugin that gives me a deprecation warning on android), then why should we waste our time? Google has literally billions of dollars at their disposal, they hire the best engineers, and then they let things like this remain unresolved for years? No way I am going to do their work for them. / endrant :).

On a less ranty note, your code saved my bacon yesterday. Client is super stoked that they can keep listening to music while using the app. So even though Google basically threw you to the curb, I super appreciate your efforts!

[ollyde]

Hey guys, any sign this will get fixed? Have several apps on the store with silent video content; getting lots of feedback from users saying it keeping pausing their music / podcasts.. not good..

[jbirori]

Is there a timeline of when this might be fixed and merged in?

[shovelmn12]

any news?

[ollyde]

Is there any news on this? It's really annoying our users! The patch that was offered doesn't work anymore.

[obrunsmann]

It's very annoying... it is really not possible that for such fundamental problems after more than a year neither a solution is accepted nor other proposals are released... I like Flutter very much, but it simply destroys production use cases.

https://github.com/crazedVic/plugins worked for me.. thank you @crazedVic !

[ollyde]

@eseidelGoogle

[w3ggy]

Still not merged

[cyanglaz]

@wwwdata Sorry for the delay. The PR looks good. If you could please rebase and I can land it.

[shovelmn12]

@cyanglaz Thanks lots of us are waiting for this :)

[tvolkert]

if you want to take this topic over, go ahead and open a PR with your fixes. Link it here so we now that you took over then I gladly close my PR. For me, this is just a way too long ongoing process right now and I don't have time for this issue anymore.

@wwwdata I understand your frustration. Can you let @cyanglaz know if you're planning on rebasing so he can land, or if you'd prefer someone else to do so?

[wwwdata]

Hi. I can rebase it again. But this weekend I have no time. I will do it next week. Maybe Monday/Tuesday. Would be great to finally merge this in 😂

[tvolkert]

Sounds good - thank you so much for your patience! 🙂

[cyanglaz]

@wwwdata Thank you! Feel free to @ me after the rebase. I will work on landing it!

[wwwdata]

Hi, I did the work now but unfortunately, I lost access to the repo I originally opened the pull request from because I don't work for this company anymore. I created another PR with my changes here. Sorry for the inconvenience: #2922

[tvolkert]

No worries! Thanks for sticking with it - I'll close this now and move discussion over to #2922

[tvolkert]

FYI, this landed in #2939. THANK YOU @wwwdata!! 🙏